Re: [Intel-gfx] [PATCH] drm/i915: Don't clobber crtc-fb when queue_flip fails

2013-03-03 Thread Daniel Vetter
On Fri, Feb 22, 2013 at 04:36:38PM +0200, Ville Syrjälä wrote: I don't think anyone should be poking at crtc-fb w/o holding the crtc mutex. Except that intel_update_fbc() actually does. That thing would appear to be just broken since it crawls around in the crtc state w/o proper protection.

[Intel-gfx] [PATCH] drm/i915: Don't clobber crtc-fb when queue_flip fails

2013-02-22 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Point crtc-fb the the new framebuffer only after we know that the flip was succesfully queued. While at it, move the intel_fb and obj assignments a bit close to where they're used. Cc: sta...@vger.kernel.org Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH] drm/i915: Don't clobber crtc-fb when queue_flip fails

2013-02-22 Thread Mika Kuoppala
ville.syrj...@linux.intel.com writes: From: Ville Syrjälä ville.syrj...@linux.intel.com Point crtc-fb the the new framebuffer only after we know that the flip was succesfully queued. While at it, move the intel_fb and obj assignments a bit close to where they're used. Cc:

Re: [Intel-gfx] [PATCH] drm/i915: Don't clobber crtc-fb when queue_flip fails

2013-02-22 Thread Ville Syrjälä
On Fri, Feb 22, 2013 at 01:31:35PM +, Chris Wilson wrote: On Fri, Feb 22, 2013 at 02:17:24PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Point crtc-fb the the new framebuffer only after we know that the flip was succesfully queued.

Re: [Intel-gfx] [PATCH] drm/i915: Don't clobber crtc-fb when queue_flip fails

2013-02-22 Thread Chris Wilson
On Fri, Feb 22, 2013 at 04:36:38PM +0200, Ville Syrjälä wrote: On Fri, Feb 22, 2013 at 01:31:35PM +, Chris Wilson wrote: On Fri, Feb 22, 2013 at 02:17:24PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Point crtc-fb the the new