Re: [Intel-gfx] [PATCH] drm/i915: Error out when trying to set a y-tiled as a sprite

2012-10-29 Thread Jesse Barnes
On Mon, 29 Oct 2012 15:20:15 + "Lespiau, Damien" wrote: > On Sun, Oct 28, 2012 at 10:04 AM, Chris Wilson > wrote: > > We do. However, we don't catch userspace changing the tiling on an > > existing fb (unless actually pinned)... The extra level of defense is > > certainly welcome, and provi

Re: [Intel-gfx] [PATCH] drm/i915: Error out when trying to set a y-tiled as a sprite

2012-10-29 Thread Ville Syrjälä
On Sun, Oct 28, 2012 at 10:04:54AM +, Chris Wilson wrote: > On Fri, 26 Oct 2012 10:42:54 -0700, Jesse Barnes > wrote: > > On Fri, 26 Oct 2012 18:30:50 +0100 > > Damien Lespiau wrote: > > > > > From: Damien Lespiau > > > > > > Signed-off-by: Damien Lespiau > > > --- > > > drivers/gpu/drm

Re: [Intel-gfx] [PATCH] drm/i915: Error out when trying to set a y-tiled as a sprite

2012-10-29 Thread Lespiau, Damien
On Sun, Oct 28, 2012 at 10:04 AM, Chris Wilson wrote: > We do. However, we don't catch userspace changing the tiling on an > existing fb (unless actually pinned)... The extra level of defense is > certainly welcome, and provides documentation at all levels on the known > capabilities of the hw. (T

Re: [Intel-gfx] [PATCH] drm/i915: Error out when trying to set a y-tiled as a sprite

2012-10-28 Thread Chris Wilson
On Fri, 26 Oct 2012 10:42:54 -0700, Jesse Barnes wrote: > On Fri, 26 Oct 2012 18:30:50 +0100 > Damien Lespiau wrote: > > > From: Damien Lespiau > > > > Signed-off-by: Damien Lespiau > > --- > > drivers/gpu/drm/i915/intel_sprite.c | 5 + > > 1 file changed, 5 insertions(+) > > > > diff

Re: [Intel-gfx] [PATCH] drm/i915: Error out when trying to set a y-tiled as a sprite

2012-10-26 Thread Jesse Barnes
On Fri, 26 Oct 2012 18:30:50 +0100 Damien Lespiau wrote: > From: Damien Lespiau > > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/intel_sprite.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_sprite.c > b/drivers/gpu/drm/i915/intel_spri

[Intel-gfx] [PATCH] drm/i915: Error out when trying to set a y-tiled as a sprite

2012-10-26 Thread Damien Lespiau
From: Damien Lespiau Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_sprite.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c index 3434b6e..aa8d09b 100644 --- a/drivers/gpu/drm/i915/intel_sprite.c