Re: [Intel-gfx] [PATCH] drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-20 Thread Joonas Lahtinen
Quoting Ville Syrjälä (2022-04-20 19:23:57) > On Wed, Apr 20, 2022 at 05:32:43PM +0200, Hans de Goede wrote: > > Hi Ville, > > > > On 4/20/22 16:03, Ville Syrjälä wrote: > > > On Mon, Apr 18, 2022 at 05:09:36PM +0200, Hans de Goede wrote: > > >> Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl pri

Re: [Intel-gfx] [PATCH] drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-20 Thread Ville Syrjälä
On Wed, Apr 20, 2022 at 05:32:43PM +0200, Hans de Goede wrote: > Hi Ville, > > On 4/20/22 16:03, Ville Syrjälä wrote: > > On Mon, Apr 18, 2022 at 05:09:36PM +0200, Hans de Goede wrote: > >> Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl primary plane registers") > >> introduced DISP_POS_Y and DI

Re: [Intel-gfx] [PATCH] drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-20 Thread Hans de Goede
Hi Ville, On 4/20/22 16:03, Ville Syrjälä wrote: > On Mon, Apr 18, 2022 at 05:09:36PM +0200, Hans de Goede wrote: >> Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl primary plane registers") >> introduced DISP_POS_Y and DISP_HEIGHT defines but accidentally set these >> their masks to REG_GENMASK(

Re: [Intel-gfx] [PATCH] drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-20 Thread Ville Syrjälä
On Mon, Apr 18, 2022 at 05:09:36PM +0200, Hans de Goede wrote: > Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl primary plane registers") > introduced DISP_POS_Y and DISP_HEIGHT defines but accidentally set these > their masks to REG_GENMASK(31, 0) instead of REG_GENMASK(31, 16). > > This breaks

Re: [Intel-gfx] [PATCH] drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-18 Thread Souza, Jose
On Mon, 2022-04-18 at 17:09 +0200, Hans de Goede wrote: > Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl primary plane registers") > introduced DISP_POS_Y and DISP_HEIGHT defines but accidentally set these > their masks to REG_GENMASK(31, 0) instead of REG_GENMASK(31, 16). > > This breaks the pr

[Intel-gfx] [PATCH] drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-18 Thread Hans de Goede
Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl primary plane registers") introduced DISP_POS_Y and DISP_HEIGHT defines but accidentally set these their masks to REG_GENMASK(31, 0) instead of REG_GENMASK(31, 16). This breaks the primary display pane on at least pineview machines, fix the mask to