Re: [Intel-gfx] [PATCH] drm/i915: Fix ICL output CSC programming

2019-05-01 Thread Clinton Taylor
On 4/26/19 12:31 AM, Lucas De Marchi wrote: On Thu, Apr 25, 2019 at 12:24 PM Ville Syrjala wrote: From: Ville Syrjälä When I refactored the code into its own function I accidentally misplaced the <<16 shifts for some of the registers causing us to lose the blue channel entirely. We should r

Re: [Intel-gfx] [PATCH] drm/i915: Fix ICL output CSC programming

2019-04-29 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjala [mailto:ville.syrj...@linux.intel.com] >Sent: Friday, April 26, 2019 12:54 AM >To: intel-gfx@lists.freedesktop.org >Cc: Shankar, Uma >Subject: [PATCH] drm/i915: Fix ICL output CSC programming > >From: Ville Syrjälä > >When I refactored the code i

Re: [Intel-gfx] [PATCH] drm/i915: Fix ICL output CSC programming

2019-04-26 Thread Sharma, Swati2
Reviewed-by: Swati Sharma Thanks and Regards, Swati -Original Message- From: Intel-gfx On Behalf Of Ville Syrjala Sent: Friday, April 26, 2019 12:54 AM To: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH] drm/i915: Fix ICL output CSC programming From: Ville Syrjälä When

Re: [Intel-gfx] [PATCH] drm/i915: Fix ICL output CSC programming

2019-04-26 Thread Lucas De Marchi
On Thu, Apr 25, 2019 at 12:24 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > When I refactored the code into its own function I accidentally > misplaced the <<16 shifts for some of the registers causing us > to lose the blue channel entirely. > > We should really find a way to test this... >

[Intel-gfx] [PATCH] drm/i915: Fix ICL output CSC programming

2019-04-25 Thread Ville Syrjala
From: Ville Syrjälä When I refactored the code into its own function I accidentally misplaced the <<16 shifts for some of the registers causing us to lose the blue channel entirely. We should really find a way to test this... Cc: Uma Shankar Fixes: d2c19b06d6ea ("drm/i915: Clean up ilk/icl pip