Re: [Intel-gfx] [PATCH] drm/i915: Fix WARN_ON condition for cursor plane ddb allocation

2019-12-16 Thread Ville Syrjälä
On Mon, Dec 16, 2019 at 01:36:19PM +0530, Vandita Kulkarni wrote: > In some cases like latency[level]==0, wm[level].res_lines>31, > min_ddb_alloc can be U16_MAX, exclude it from the WARN_ON. > > v2: Specify the cases in which we hit U16_MAX, indentation (Ville) > > Fixes: 10a7e07b68b9 ("drm/i915:

[Intel-gfx] [PATCH] drm/i915: Fix WARN_ON condition for cursor plane ddb allocation

2019-12-16 Thread Vandita Kulkarni
In some cases like latency[level]==0, wm[level].res_lines>31, min_ddb_alloc can be U16_MAX, exclude it from the WARN_ON. v2: Specify the cases in which we hit U16_MAX, indentation (Ville) Fixes: 10a7e07b68b9 ("drm/i915: Make sure cursor has enough ddb for the selected wm level") Suggested-by: Vi

Re: [Intel-gfx] [PATCH] drm/i915: Fix WARN_ON condition for cursor plane ddb allocation

2019-12-13 Thread Ville Syrjälä
On Fri, Dec 13, 2019 at 09:15:15PM +0530, Vandita Kulkarni wrote: > In some cases min_ddb_alloc can be U16_MAX, exclude it > from the WARN_ON. The two cases I think are: latency[level]==0 or wm[level].res_lines>31 You said you hit the latter case. May want to mention those in the commit message.

[Intel-gfx] [PATCH] drm/i915: Fix WARN_ON condition for cursor plane ddb allocation

2019-12-13 Thread Vandita Kulkarni
In some cases min_ddb_alloc can be U16_MAX, exclude it from the WARN_ON. Fixes: 10a7e07b68b9 ("drm/i915: Make sure cursor has enough ddb for the selected wm level") Suggested-by: Ville Syrjälä Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/intel_pm.c | 6 -- 1 file changed, 4 ins