[Intel-gfx] [PATCH] drm/i915: Fix oops in vlv_force_pll_on()

2016-04-18 Thread ville . syrjala
From: Ville Syrjälä intel_pipe_will_have_type() doesn't just look at the passied in pipe_config, instead it expects there to be a full atomic state behind it. Obviously that won't go so well when vlv_force_pll_on() just uses a temp pipe_config. Fix things by using pipe_config->has_dsi_encoder ins

Re: [Intel-gfx] [PATCH] drm/i915: Fix oops in vlv_force_pll_on()

2016-04-19 Thread Marius Vlad
LGTM. Tested-By: Marius Vlad. On Mon, Apr 18, 2016 at 08:34:04PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > intel_pipe_will_have_type() doesn't just look at the passied in > pipe_config, instead it expects there to be a full atomic state behind > it. Obviously that wo

Re: [Intel-gfx] [PATCH] drm/i915: Fix oops in vlv_force_pll_on()

2016-04-19 Thread Jani Nikula
On Mon, 18 Apr 2016, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > intel_pipe_will_have_type() doesn't just look at the passied in > pipe_config, instead it expects there to be a full atomic state behind > it. Obviously that won't go so well when vlv_force_pll_on() just uses a > t

Re: [Intel-gfx] [PATCH] drm/i915: Fix oops in vlv_force_pll_on()

2016-04-19 Thread Ville Syrjälä
On Tue, Apr 19, 2016 at 02:25:40PM +0300, Jani Nikula wrote: > On Mon, 18 Apr 2016, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > intel_pipe_will_have_type() doesn't just look at the passied in > > pipe_config, instead it expects there to be a full atomic state behind > > it

Re: [Intel-gfx] [PATCH] drm/i915: Fix oops in vlv_force_pll_on()

2016-04-20 Thread Daniel Vetter
On Tue, Apr 19, 2016 at 03:01:31PM +0300, Ville Syrjälä wrote: > On Tue, Apr 19, 2016 at 02:25:40PM +0300, Jani Nikula wrote: > > On Mon, 18 Apr 2016, ville.syrj...@linux.intel.com wrote: > > > From: Ville Syrjälä > > > > > > intel_pipe_will_have_type() doesn't just look at the passied in > > > pi

Re: [Intel-gfx] [PATCH] drm/i915: Fix oops in vlv_force_pll_on()

2016-04-20 Thread Ville Syrjälä
On Wed, Apr 20, 2016 at 03:19:49PM +0200, Daniel Vetter wrote: > On Tue, Apr 19, 2016 at 03:01:31PM +0300, Ville Syrjälä wrote: > > On Tue, Apr 19, 2016 at 02:25:40PM +0300, Jani Nikula wrote: > > > On Mon, 18 Apr 2016, ville.syrj...@linux.intel.com wrote: > > > > From: Ville Syrjälä > > > > > > >