Re: [Intel-gfx] [PATCH] drm/i915: Handle runtime pm in the CRC setup code

2014-11-25 Thread Damien Lespiau
On Mon, Nov 24, 2014 at 09:43:12PM +0100, Daniel Vetter wrote: Note that we need the rpm_get/put to make power_is_enabled work properly. I still don't get that. intel_display_power_is_enabled() only checks for states kept in dev_priv. In particular, it doesn't touch the hardware and it looks at

[Intel-gfx] [PATCH] drm/i915: Handle runtime pm in the CRC setup code

2014-11-25 Thread Daniel Vetter
The crc code doesn't handle anything really that could drop the register state (by design so that we have less complexity). Which means userspace may only start crc capture once the pipe is fully set up. With an i-g-t patch this will be the case, but there's still the problem that this results in

Re: [Intel-gfx] [PATCH] drm/i915: Handle runtime pm in the CRC setup code

2014-11-25 Thread Damien Lespiau
On Tue, Nov 25, 2014 at 02:08:10PM +0100, Daniel Vetter wrote: The crc code doesn't handle anything really that could drop the register state (by design so that we have less complexity). Which means userspace may only start crc capture once the pipe is fully set up. With an i-g-t patch this

[Intel-gfx] [PATCH] drm/i915: Handle runtime pm in the CRC setup code

2014-11-24 Thread Daniel Vetter
The crc code doesn't handle anything really that could drop the register state (by design so that we have less complexity). Which means userspace may only start crc capture once the pipe is fully set up. With an i-g-t patch this will be the case, but there's still the problem that this results in

Re: [Intel-gfx] [PATCH] drm/i915: Handle runtime pm in the CRC setup code

2014-11-24 Thread Damien Lespiau
On Mon, Nov 24, 2014 at 04:23:36PM +0100, Daniel Vetter wrote: The crc code doesn't handle anything really that could drop the register state (by design so that we have less complexity). Which means userspace may only start crc capture once the pipe is fully set up. With an i-g-t patch this

Re: [Intel-gfx] [PATCH] drm/i915: Handle runtime pm in the CRC setup code

2014-11-24 Thread Daniel Vetter
On Mon, Nov 24, 2014 at 4:36 PM, Damien Lespiau damien.lesp...@intel.com wrote: On Mon, Nov 24, 2014 at 04:23:36PM +0100, Daniel Vetter wrote: The crc code doesn't handle anything really that could drop the register state (by design so that we have less complexity). Which means userspace may

[Intel-gfx] [PATCH] drm/i915: Handle runtime pm in the CRC setup code

2014-11-24 Thread Daniel Vetter
The crc code doesn't handle anything really that could drop the register state (by design so that we have less complexity). Which means userspace may only start crc capture once the pipe is fully set up. With an i-g-t patch this will be the case, but there's still the problem that this results in