Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-28 Thread Maarten Lankhorst
Op 27-01-2022 om 13:45 schreef Thomas Hellström: > > On 1/27/22 13:38, Maarten Lankhorst wrote: >> Op 27-01-2022 om 13:09 schreef Thomas Hellström: >>> On 1/27/22 13:05, Thomas Hellström wrote: > The bug on vm_close is a separate bug, and would probably best be > fixed in a separate patch.

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Thomas Hellström
On 1/27/22 13:38, Maarten Lankhorst wrote: Op 27-01-2022 om 13:09 schreef Thomas Hellström: On 1/27/22 13:05, Thomas Hellström wrote: The bug on vm_close is a separate bug, and would probably best be fixed in a separate patch. Could I get a r-b on this? It should fix some issues, even if the

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Maarten Lankhorst
Op 27-01-2022 om 13:09 schreef Thomas Hellström: > > On 1/27/22 13:05, Thomas Hellström wrote: >> >>> The bug on vm_close is a separate bug, and would probably best be >>> fixed in a separate patch. >>> >>> Could I get a r-b on this? It should fix some issues, even if the >>> unbind there is a sepa

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Thomas Hellström
On 1/27/22 13:05, Thomas Hellström wrote: The bug on vm_close is a separate bug, and would probably best be fixed in a separate patch. Could I get a r-b on this? It should fix some issues, even if the unbind there is a separate bug. ~Maarten Recognizing that it doesn't fix the vm_close is

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Thomas Hellström
On Thu, 2022-01-27 at 13:02 +0100, Maarten Lankhorst wrote: > Op 26-01-2022 om 13:55 schreef Gwan-gyeong Mun: > > > > > > On 1/26/22 9:37 AM, Maarten Lankhorst wrote: > > > set_cache_level may unbind the object, which will result in the > > > below > > > lockdep splat: > > > <6> [184.578145] [IGT

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Maarten Lankhorst
Op 26-01-2022 om 13:55 schreef Gwan-gyeong Mun: > > > On 1/26/22 9:37 AM, Maarten Lankhorst wrote: >> set_cache_level may unbind the object, which will result in the below >> lockdep splat: >> <6> [184.578145] [IGT] kms_addfb_basic: starting subtest >> addfb25-framebuffer-vs-set-tiling >> <4> [184

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-26 Thread Gwan-gyeong Mun
On 1/26/22 9:37 AM, Maarten Lankhorst wrote: set_cache_level may unbind the object, which will result in the below lockdep splat: <6> [184.578145] [IGT] kms_addfb_basic: starting subtest addfb25-framebuffer-vs-set-tiling <4> [184.578220] [ cut here ] <4> [184.578221] W

[Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-25 Thread Maarten Lankhorst
set_cache_level may unbind the object, which will result in the below lockdep splat: <6> [184.578145] [IGT] kms_addfb_basic: starting subtest addfb25-framebuffer-vs-set-tiling <4> [184.578220] [ cut here ] <4> [184.578221] WARN_ON(debug_locks && !(lock_is_held(&(&((obj)->b