[Intel-gfx] [PATCH] drm/i915: Neuter virtual rq->engine on retire

2020-05-19 Thread Chris Wilson
We do not hold a reference to rq->engine, and so if it is a virtual engine it may have already been freed by the time we free the request. The last reference we hold on the virtual engine is via rq->context, and that is released on request retirement. So if we find ourselves retiring a virtual requ

Re: [Intel-gfx] [PATCH] drm/i915: Neuter virtual rq->engine on retire

2020-05-19 Thread Chris Wilson
Quoting Chris Wilson (2020-05-19 15:51:31) > We do not hold a reference to rq->engine, and so if it is a virtual > engine it may have already been freed by the time we free the request. > The last reference we hold on the virtual engine is via rq->context, > and that is released on request retireme

Re: [Intel-gfx] [PATCH] drm/i915: Neuter virtual rq->engine on retire

2020-05-19 Thread Chris Wilson
Quoting Chris Wilson (2020-05-19 18:00:04) > Quoting Chris Wilson (2020-05-19 15:51:31) > > We do not hold a reference to rq->engine, and so if it is a virtual > > engine it may have already been freed by the time we free the request. > > The last reference we hold on the virtual engine is via rq->