Re: [Intel-gfx] [PATCH] drm/i915: Pin tiled objects for L-shaped configs

2015-04-07 Thread Daniel Vetter
On Fri, Apr 03, 2015 at 10:43:29AM +0100, Chris Wilson wrote: On Thu, Nov 20, 2014 at 09:26:30AM +0100, Daniel Vetter wrote: diff --git a/drivers/gpu/drm/i915/i915_gem_tiling.c b/drivers/gpu/drm/i915/i915_gem_tiling.c index 749ab485569e..03c675a4476e 100644 ---

Re: [Intel-gfx] [PATCH] drm/i915: Pin tiled objects for L-shaped configs

2015-04-07 Thread Chris Wilson
On Tue, Apr 07, 2015 at 10:05:39AM +0200, Daniel Vetter wrote: On Fri, Apr 03, 2015 at 10:43:29AM +0100, Chris Wilson wrote: I resurrected my dual-channel evenly loaded gm45 and to my surprise found it reporting a L-shaped memory layout. Well my gm45 is also dual-channel and evenly loaded

Re: [Intel-gfx] [PATCH] drm/i915: Pin tiled objects for L-shaped configs

2015-04-03 Thread Chris Wilson
On Thu, Nov 20, 2014 at 09:26:30AM +0100, Daniel Vetter wrote: diff --git a/drivers/gpu/drm/i915/i915_gem_tiling.c b/drivers/gpu/drm/i915/i915_gem_tiling.c index 749ab485569e..03c675a4476e 100644 --- a/drivers/gpu/drm/i915/i915_gem_tiling.c +++ b/drivers/gpu/drm/i915/i915_gem_tiling.c @@

[Intel-gfx] [PATCH] drm/i915: Pin tiled objects for L-shaped configs

2014-11-20 Thread Daniel Vetter
Let's just throw in the towel on this one and take the cheap way out. Based on a patch from Chris Wilson, but checking for a different bit. Chris' patch checked for even bank layout, this one here for a magic bit. Given the evidence we've gathered (not much) both work I think, but checking for

Re: [Intel-gfx] [PATCH] drm/i915: Pin tiled objects for L-shaped configs

2014-11-20 Thread Chris Wilson
On Thu, Nov 20, 2014 at 09:26:30AM +0100, Daniel Vetter wrote: Let's just throw in the towel on this one and take the cheap way out. Based on a patch from Chris Wilson, but checking for a different bit. Chris' patch checked for even bank layout, this one here for a magic bit. Given the

Re: [Intel-gfx] [PATCH] drm/i915: Pin tiled objects for L-shaped configs

2014-11-20 Thread Daniel Vetter
On Thu, Nov 20, 2014 at 08:37:36AM +, Chris Wilson wrote: On Thu, Nov 20, 2014 at 09:26:30AM +0100, Daniel Vetter wrote: Let's just throw in the towel on this one and take the cheap way out. Based on a patch from Chris Wilson, but checking for a different bit. Chris' patch checked

Re: [Intel-gfx] [PATCH] drm/i915: Pin tiled objects for L-shaped configs

2014-11-20 Thread Chris Wilson
On Thu, Nov 20, 2014 at 10:22:42AM +0100, Daniel Vetter wrote: On Thu, Nov 20, 2014 at 08:37:36AM +, Chris Wilson wrote: Oh, one more request: can I haz decoded quirks in the error state? Hm, I haven't ever yet wanted to see them. Not even sure whether this might be useful here really

[Intel-gfx] [PATCH] drm/i915: Pin tiled objects for L-shaped configs

2014-11-18 Thread Daniel Vetter
Let's just throw in the towel on this one and take the cheap way out. Based on a patch from Chris Wilson, but checking for a different bit. Chris' patch checked for even bank layout, this one here for a magic bit. Given the evidence we've gathered (not much) both work I think, but checking for

Re: [Intel-gfx] [PATCH] drm/i915: Pin tiled objects for L-shaped configs

2014-11-18 Thread Chris Wilson
On Tue, Nov 18, 2014 at 02:41:22PM +0100, Daniel Vetter wrote: struct intel_fbdev; struct intel_fbc_work; diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 1de94cc63517..196ebd07d118 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++

Re: [Intel-gfx] [PATCH] drm/i915: Pin tiled objects for L-shaped configs

2014-11-18 Thread Daniel Vetter
On Tue, Nov 18, 2014 at 02:01:37PM +, Chris Wilson wrote: On Tue, Nov 18, 2014 at 02:41:22PM +0100, Daniel Vetter wrote: struct intel_fbdev; struct intel_fbc_work; diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 1de94cc63517..196ebd07d118