[Intel-gfx] [PATCH] drm/i915: Prevent signals from interrupting close()

2014-04-09 Thread Chris Wilson
We neither report any unfinished operations during releasing GEM objects associated with the file, and even if we did, it is bad form to report -EINTR from a close(). The root cause of the bug that first showed itself during close is that we do not do proper live tracking of vma and contexts under

Re: [Intel-gfx] [PATCH] drm/i915: Prevent signals from interrupting close()

2014-04-09 Thread Daniel Vetter
On Wed, Apr 09, 2014 at 08:03:39AM +0100, Chris Wilson wrote: > We neither report any unfinished operations during releasing GEM objects > associated with the file, and even if we did, it is bad form to report > -EINTR from a close(). > > The root cause of the bug that first showed itself during c

Re: [Intel-gfx] [PATCH] drm/i915: Prevent signals from interrupting close()

2014-04-09 Thread Chris Wilson
On Wed, Apr 09, 2014 at 04:49:02PM +0200, Daniel Vetter wrote: > On Wed, Apr 09, 2014 at 08:03:39AM +0100, Chris Wilson wrote: > > We neither report any unfinished operations during releasing GEM objects > > associated with the file, and even if we did, it is bad form to report > > -EINTR from a cl

Re: [Intel-gfx] [PATCH] drm/i915: Prevent signals from interrupting close()

2014-04-09 Thread Daniel Vetter
On Wed, Apr 09, 2014 at 04:03:23PM +0100, Chris Wilson wrote: > On Wed, Apr 09, 2014 at 04:49:02PM +0200, Daniel Vetter wrote: > > On Wed, Apr 09, 2014 at 08:03:39AM +0100, Chris Wilson wrote: > > > We neither report any unfinished operations during releasing GEM objects > > > associated with the f

Re: [Intel-gfx] [PATCH] drm/i915: Prevent signals from interrupting close()

2014-04-09 Thread Chris Wilson
On Wed, Apr 09, 2014 at 06:50:03PM +0200, Daniel Vetter wrote: > On Wed, Apr 09, 2014 at 04:03:23PM +0100, Chris Wilson wrote: > > On Wed, Apr 09, 2014 at 04:49:02PM +0200, Daniel Vetter wrote: > > > On Wed, Apr 09, 2014 at 08:03:39AM +0100, Chris Wilson wrote: > > > > We neither report any unfinis

Re: [Intel-gfx] [PATCH] drm/i915: Prevent signals from interrupting close()

2014-04-09 Thread Ben Widawsky
On Wed, Apr 09, 2014 at 08:03:39AM +0100, Chris Wilson wrote: > We neither report any unfinished operations during releasing GEM objects > associated with the file, and even if we did, it is bad form to report > -EINTR from a close(). > > The root cause of the bug that first showed itself during c

Re: [Intel-gfx] [PATCH] drm/i915: Prevent signals from interrupting close()

2014-04-09 Thread Chris Wilson
On Wed, Apr 09, 2014 at 10:43:47AM -0700, Ben Widawsky wrote: > On Wed, Apr 09, 2014 at 08:03:39AM +0100, Chris Wilson wrote: > > We neither report any unfinished operations during releasing GEM objects > > associated with the file, and even if we did, it is bad form to report > > -EINTR from a clo

Re: [Intel-gfx] [PATCH] drm/i915: Prevent signals from interrupting close()

2014-04-10 Thread Ben Widawsky
On Wed, Apr 09, 2014 at 06:58:41PM +0100, Chris Wilson wrote: > On Wed, Apr 09, 2014 at 10:43:47AM -0700, Ben Widawsky wrote: > > On Wed, Apr 09, 2014 at 08:03:39AM +0100, Chris Wilson wrote: > > > We neither report any unfinished operations during releasing GEM objects > > > associated with the fi