Re: [Intel-gfx] [PATCH] drm/i915: Remove WARN_ON and WARN_ON_ONCE overrides.

2020-04-02 Thread Jani Nikula
On Thu, 02 Apr 2020, Daniel Vetter wrote: > On Thu, Apr 2, 2020 at 8:23 AM Jani Nikula > wrote: >> >> On Thu, 02 Apr 2020, Pankaj Bharadiya >> wrote: >> > Now we have new struct drm_device based drm_WARN* macros. These are >> > preferred over the regular WARN* macros. >> > >> > Remove WARN_ON

Re: [Intel-gfx] [PATCH] drm/i915: Remove WARN_ON and WARN_ON_ONCE overrides.

2020-04-02 Thread Daniel Vetter
On Thu, Apr 2, 2020 at 8:23 AM Jani Nikula wrote: > > On Thu, 02 Apr 2020, Pankaj Bharadiya > wrote: > > Now we have new struct drm_device based drm_WARN* macros. These are > > preferred over the regular WARN* macros. > > > > Remove WARN_ON and WARN_ON_ONCE overriedes to avoid any temptations to

Re: [Intel-gfx] [PATCH] drm/i915: Remove WARN_ON and WARN_ON_ONCE overrides.

2020-04-01 Thread Jani Nikula
On Thu, 02 Apr 2020, Pankaj Bharadiya wrote: > Now we have new struct drm_device based drm_WARN* macros. These are > preferred over the regular WARN* macros. > > Remove WARN_ON and WARN_ON_ONCE overriedes to avoid any temptations to > use them in the future. Well, since they are overrides of mac

[Intel-gfx] [PATCH] drm/i915: Remove WARN_ON and WARN_ON_ONCE overrides.

2020-04-01 Thread Pankaj Bharadiya
Now we have new struct drm_device based drm_WARN* macros. These are preferred over the regular WARN* macros. Remove WARN_ON and WARN_ON_ONCE overriedes to avoid any temptations to use them in the future. Suggested-by: Jani Nikula Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/i915_ut