Re: [Intel-gfx] [PATCH] drm/i915: Remove WaDisableKillLogic and GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC for KBL and GLK.

2017-06-19 Thread Ville Syrjälä
On Mon, Jun 19, 2017 at 07:01:21PM +, Vivi, Rodrigo wrote: > On Mon, 2017-06-19 at 21:22 +0300, Ville Syrjälä wrote: > > On Mon, Jun 19, 2017 at 10:23:41AM -0700, Rodrigo Vivi wrote: > > > When reviewing commit 46c26662d2f ("drm/i915/cfl: Introduce Coffee Lake > > > workarounds.") > > > Mika

Re: [Intel-gfx] [PATCH] drm/i915: Remove WaDisableKillLogic and GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC for KBL and GLK.

2017-06-19 Thread Vivi, Rodrigo
On Mon, 2017-06-19 at 21:22 +0300, Ville Syrjälä wrote: > On Mon, Jun 19, 2017 at 10:23:41AM -0700, Rodrigo Vivi wrote: > > When reviewing commit 46c26662d2f ("drm/i915/cfl: Introduce Coffee Lake > > workarounds.") > > Mika pointed out that Spec tells those 2 workarounds were not needed. > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Remove WaDisableKillLogic and GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC for KBL and GLK.

2017-06-19 Thread Ville Syrjälä
On Mon, Jun 19, 2017 at 10:23:41AM -0700, Rodrigo Vivi wrote: > When reviewing commit 46c26662d2f ("drm/i915/cfl: Introduce Coffee Lake > workarounds.") > Mika pointed out that Spec tells those 2 workarounds were not needed. > > So when double checking I confirmed that and also that by Spec >

[Intel-gfx] [PATCH] drm/i915: Remove WaDisableKillLogic and GEN9_DISABLE_OCL_OOB_SUPPRESS_LOGIC for KBL and GLK.

2017-06-19 Thread Rodrigo Vivi
When reviewing commit 46c26662d2f ("drm/i915/cfl: Introduce Coffee Lake workarounds.") Mika pointed out that Spec tells those 2 workarounds were not needed. So when double checking I confirmed that and also that by Spec they only apply to SKL and BXT. v2: Instead of increase the if/else move