Re: [Intel-gfx] [PATCH] drm/i915: Remove overzealous fence warn on runtime suspend

2017-02-07 Thread Chris Wilson
On Tue, Feb 07, 2017 at 04:24:25PM +0200, Joonas Lahtinen wrote: > On pe, 2017-02-03 at 12:57 +, Chris Wilson wrote: > > @@ -2024,8 +2024,16 @@ void i915_gem_runtime_suspend(struct > > drm_i915_private *dev_priv) > >   for (i = 0; i < dev_priv->num_fence_regs; i++) { > >   struct d

Re: [Intel-gfx] [PATCH] drm/i915: Remove overzealous fence warn on runtime suspend

2017-02-07 Thread Joonas Lahtinen
On pe, 2017-02-03 at 12:57 +, Chris Wilson wrote: > The goal of the WARN was to catch when we are still actively using the > fence as we go into the runtime suspend. However, the reg->pin_count is > too coarse as it does not distinguish between exclusive ownership of the > fence register from a

[Intel-gfx] [PATCH] drm/i915: Remove overzealous fence warn on runtime suspend

2017-02-03 Thread Chris Wilson
The goal of the WARN was to catch when we are still actively using the fence as we go into the runtime suspend. However, the reg->pin_count is too coarse as it does not distinguish between exclusive ownership of the fence register from activity. I've not improved on the WARN, nor have we captured