Re: [Intel-gfx] [PATCH] drm/i915: Remove redundant check for negative timeout while doing an atomic pipe update

2018-05-01 Thread Manasi Navare
On Tue, May 01, 2018 at 01:39:15PM -0700, Tarun Vyas wrote: > Just a minor knit. Stumbled across the kernel doc for schedule_timeout() which > quotes "In all cases the return value is guaranteed to be non-negative". Also, > the return code of schedule_timeout() already checks for negative values >

[Intel-gfx] [PATCH] drm/i915: Remove redundant check for negative timeout while doing an atomic pipe update

2018-05-01 Thread Tarun Vyas
Just a minor knit. Stumbled across the kernel doc for schedule_timeout() which quotes "In all cases the return value is guaranteed to be non-negative". Also, the return code of schedule_timeout() already checks for negative values "return timeout < 0 ? 0 : timeout;" and returns 0 in such cases. So,