Re: [Intel-gfx] [PATCH] drm/i915: Retry port as HDMI if dp_is_edp turns out to be false

2015-08-12 Thread Ville Syrjälä
On Wed, Aug 12, 2015 at 03:14:53PM +0100, Chris Wilson wrote: On Wed, Aug 12, 2015 at 04:45:39PM +0300, Ville Syrjälä wrote: - /* - * For eDP we always set the encoder type to INTEL_OUTPUT_EDP, but - * for DP the encoder type can be set by the caller to - * INTEL_OUTPUT_UNKNOWN for

Re: [Intel-gfx] [PATCH] drm/i915: Retry port as HDMI if dp_is_edp turns out to be false

2015-08-12 Thread Chris Wilson
On Wed, Aug 12, 2015 at 04:45:39PM +0300, Ville Syrjälä wrote: - /* -* For eDP we always set the encoder type to INTEL_OUTPUT_EDP, but -* for DP the encoder type can be set by the caller to -* INTEL_OUTPUT_UNKNOWN for DDI, so don't rewrite it. -*/ - if (type ==

Re: [Intel-gfx] [PATCH] drm/i915: Retry port as HDMI if dp_is_edp turns out to be false

2015-08-12 Thread Ville Syrjälä
On Sun, Aug 09, 2015 at 01:12:53PM +0100, Chris Wilson wrote: We follow the VBT as to whether a DDI port is used for eDP and if so, do not attach a HDMI encoder to it. However there are machines for which the VBT eDP flag is a lie (shocking!) and we fail to detect a eDP link. Furthermore, on

Re: [Intel-gfx] [PATCH] drm/i915: Retry port as HDMI if dp_is_edp turns out to be false

2015-08-10 Thread Sivakumar Thulasimani
hi Mengdong, is there any reason why you cannot modify VBT ? unless it is shipped version you can just flash the modified VBT along with BIOS. Chris, i would be even more surprised if VBIOS/GOP can enable some display when it is configured incorrectly in VBT. Give me a day to check

Re: [Intel-gfx] [PATCH] drm/i915: Retry port as HDMI if dp_is_edp turns out to be false

2015-08-10 Thread Chris Wilson
On Mon, Aug 10, 2015 at 04:05:31PM +0530, Sivakumar Thulasimani wrote: Chris, After asking few people found that the simplest explanation and plausible root cause being that PORT D is set for both eDP and HDMI :). in which case the proper fix is to check in intel_dp_is_edp, if PORT D is

Re: [Intel-gfx] [PATCH] drm/i915: Retry port as HDMI if dp_is_edp turns out to be false

2015-08-10 Thread Sivakumar Thulasimani
Chris, After asking few people found that the simplest explanation and plausible root cause being that PORT D is set for both eDP and HDMI :). in which case the proper fix is to check in intel_dp_is_edp, if PORT D is again set for any other display and return false if that is the case or

[Intel-gfx] [PATCH] drm/i915: Retry port as HDMI if dp_is_edp turns out to be false

2015-08-09 Thread Chris Wilson
We follow the VBT as to whether a DDI port is used for eDP and if so, do not attach a HDMI encoder to it. However there are machines for which the VBT eDP flag is a lie (shocking!) and we fail to detect a eDP link. Furthermore, on those machines the HDMI is connected to that DDI port but we ignore

Re: [Intel-gfx] [PATCH] drm/i915: Retry port as HDMI if dp_is_edp turns out to be false

2015-08-09 Thread Lukas Wunner
Hi, On Sun, Aug 09, 2015 at 01:12:53PM +0100, Chris Wilson wrote: We follow the VBT as to whether a DDI port is used for eDP and if so, do not attach a HDMI encoder to it. However there are machines for which the VBT eDP flag is a lie (shocking!) and we fail to detect a eDP link. Furthermore,

Re: [Intel-gfx] [PATCH] drm/i915: Retry port as HDMI if dp_is_edp turns out to be false

2015-08-09 Thread Lin, Mengdong
-Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Lukas Wunner Hi, On Sun, Aug 09, 2015 at 01:12:53PM +0100, Chris Wilson wrote: We follow the VBT as to whether a DDI port is used for eDP and if so, do not attach a HDMI encoder to