Re: [Intel-gfx] [PATCH] drm/i915: Unwind partial VMA rebinding after failure in set-cache-level

2015-10-09 Thread Chris Wilson
On Fri, Oct 09, 2015 at 01:37:19PM +0100, Tvrtko Ursulin wrote: > > On 09/10/15 13:19, Chris Wilson wrote: > >On Fri, Oct 09, 2015 at 01:11:47PM +0100, Tvrtko Ursulin wrote: > >> > >>On 09/10/15 12:51, Chris Wilson wrote: > >>>If the impossible happens and we fail to rebind a VMA in the middle of

Re: [Intel-gfx] [PATCH] drm/i915: Unwind partial VMA rebinding after failure in set-cache-level

2015-10-09 Thread Tvrtko Ursulin
On 09/10/15 13:19, Chris Wilson wrote: On Fri, Oct 09, 2015 at 01:11:47PM +0100, Tvrtko Ursulin wrote: On 09/10/15 12:51, Chris Wilson wrote: If the impossible happens and we fail to rebind a VMA in the middle of rebinding all VMA for an object we currently bail out and leave the object in an

Re: [Intel-gfx] [PATCH] drm/i915: Unwind partial VMA rebinding after failure in set-cache-level

2015-10-09 Thread Chris Wilson
On Fri, Oct 09, 2015 at 01:11:47PM +0100, Tvrtko Ursulin wrote: > > On 09/10/15 12:51, Chris Wilson wrote: > >If the impossible happens and we fail to rebind a VMA in the middle of > >rebinding all VMA for an object we currently bail out and leave the > >object in an inconsistent state. Attempt to

Re: [Intel-gfx] [PATCH] drm/i915: Unwind partial VMA rebinding after failure in set-cache-level

2015-10-09 Thread Chris Wilson
On Fri, Oct 09, 2015 at 01:11:47PM +0100, Tvrtko Ursulin wrote: > > On 09/10/15 12:51, Chris Wilson wrote: > >If the impossible happens and we fail to rebind a VMA in the middle of > >rebinding all VMA for an object we currently bail out and leave the > >object in an inconsistent state. Attempt to

Re: [Intel-gfx] [PATCH] drm/i915: Unwind partial VMA rebinding after failure in set-cache-level

2015-10-09 Thread Tvrtko Ursulin
On 09/10/15 12:51, Chris Wilson wrote: If the impossible happens and we fail to rebind a VMA in the middle of rebinding all VMA for an object we currently bail out and leave the object in an inconsistent state. Attempt to unwind the incomplete update by reverting all updated VMA back to the orig

[Intel-gfx] [PATCH] drm/i915: Unwind partial VMA rebinding after failure in set-cache-level

2015-10-09 Thread Chris Wilson
If the impossible happens and we fail to rebind a VMA in the middle of rebinding all VMA for an object we currently bail out and leave the object in an inconsistent state. Attempt to unwind the incomplete update by reverting all updated VMA back to the original cache-level, and WARN if that fails.