[Intel-gfx] [PATCH] drm/i915: Upgrade execbuffer fail after resume failure to EIO

2014-03-25 Thread Chris Wilson
If we try to execute on a known ring, but it has failed to be initialised correctly, report that the GPU is hung rather than the command invalid. This leaves us reporting EINVAL only if the user requests execution on a ring that is not supported by the device. This should prevent UXA from getting

Re: [Intel-gfx] [PATCH] drm/i915: Upgrade execbuffer fail after resume failure to EIO

2014-03-25 Thread Daniel Vetter
On Tue, Mar 25, 2014 at 9:03 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: If we try to execute on a known ring, but it has failed to be initialised correctly, report that the GPU is hung rather than the command invalid. This leaves us reporting EINVAL only if the user requests execution on

Re: [Intel-gfx] [PATCH] drm/i915: Upgrade execbuffer fail after resume failure to EIO

2014-03-25 Thread Chris Wilson
On Tue, Mar 25, 2014 at 09:07:00AM +0100, Daniel Vetter wrote: On Tue, Mar 25, 2014 at 9:03 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: If we try to execute on a known ring, but it has failed to be initialised correctly, report that the GPU is hung rather than the command invalid.

Re: [Intel-gfx] [PATCH] drm/i915: Upgrade execbuffer fail after resume failure to EIO

2014-03-25 Thread Daniel Vetter
On Tue, Mar 25, 2014 at 08:15:54AM +, Chris Wilson wrote: On Tue, Mar 25, 2014 at 09:07:00AM +0100, Daniel Vetter wrote: On Tue, Mar 25, 2014 at 9:03 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: If we try to execute on a known ring, but it has failed to be initialised

Re: [Intel-gfx] [PATCH] drm/i915: Upgrade execbuffer fail after resume failure to EIO

2014-03-25 Thread Ben Widawsky
On Tue, Mar 25, 2014 at 08:03:28AM +, Chris Wilson wrote: If we try to execute on a known ring, but it has failed to be initialised correctly, report that the GPU is hung rather than the command invalid. This leaves us reporting EINVAL only if the user requests execution on a ring that is

Re: [Intel-gfx] [PATCH] drm/i915: Upgrade execbuffer fail after resume failure to EIO

2014-03-25 Thread Chris Wilson
On Tue, Mar 25, 2014 at 08:24:00AM -0700, Ben Widawsky wrote: On Tue, Mar 25, 2014 at 08:03:28AM +, Chris Wilson wrote: If we try to execute on a known ring, but it has failed to be initialised correctly, report that the GPU is hung rather than the command invalid. This leaves us

Re: [Intel-gfx] [PATCH] drm/i915: Upgrade execbuffer fail after resume failure to EIO

2014-03-25 Thread Chris Wilson
On Tue, Mar 25, 2014 at 04:36:05PM +0100, Daniel Vetter wrote: On Tue, Mar 25, 2014 at 08:15:54AM +, Chris Wilson wrote: On Tue, Mar 25, 2014 at 09:07:00AM +0100, Daniel Vetter wrote: On Tue, Mar 25, 2014 at 9:03 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: If we try to

Re: [Intel-gfx] [PATCH] drm/i915: Upgrade execbuffer fail after resume failure to EIO

2014-03-25 Thread Daniel Vetter
On Tue, Mar 25, 2014 at 5:29 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: Yeah I've seen the other patches. I think we should try to keep all the ring structures around even when the hw init failed. I've made some feeble attempts a while ago to split the structure init from the hw init

Re: [Intel-gfx] [PATCH] drm/i915: Upgrade execbuffer fail after resume failure to EIO

2014-03-25 Thread Chris Wilson
On Tue, Mar 25, 2014 at 05:52:00PM +0100, Daniel Vetter wrote: On Tue, Mar 25, 2014 at 5:29 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: Yeah I've seen the other patches. I think we should try to keep all the ring structures around even when the hw init failed. I've made some feeble

Re: [Intel-gfx] [PATCH] drm/i915: Upgrade execbuffer fail after resume failure to EIO

2014-03-25 Thread Daniel Vetter
On Tue, Mar 25, 2014 at 10:33 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: That, or fix the mess called ring init code ... So if we fixed resume to avoid reallocating the ringbuffers across resume, g45 would still fail to restart, but now we still have valid objects (or would we tear them