Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

On Mon, Aug 18, 2014 at 02:13:06PM +0100, Chris Wilson wrote: > On Mon, Aug 18, 2014 at 02:07:40PM +0100, Damien Lespiau wrote: > > On Mon, Aug 18, 2014 at 01:58:06PM +0100, Chris Wilson wrote: > > > On Mon, Aug 18, 2014 at 01:49:10PM +0100, Damien Lespiau wrote: > > > > Chris has decided that enou

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

On Mon, Aug 18, 2014 at 02:07:40PM +0100, Damien Lespiau wrote: > On Mon, Aug 18, 2014 at 01:58:06PM +0100, Chris Wilson wrote: > > On Mon, Aug 18, 2014 at 01:49:10PM +0100, Damien Lespiau wrote: > > > Chris has decided that enough is enough. It's time to fixup dev Vs > > > dev_priv. This is a mode

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

On Mon, Aug 18, 2014 at 01:58:06PM +0100, Chris Wilson wrote: > On Mon, Aug 18, 2014 at 01:49:10PM +0100, Damien Lespiau wrote: > > Chris has decided that enough is enough. It's time to fixup dev Vs > > dev_priv. This is a modest contribution to the crusade. > > > > v2: Still use INTEL_INFO(), for

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

On Mon, Aug 18, 2014 at 01:49:10PM +0100, Damien Lespiau wrote: > Chris has decided that enough is enough. It's time to fixup dev Vs > dev_priv. This is a modest contribution to the crusade. > > v2: Still use INTEL_INFO(), for the (mythical!) case we want to hardcode > the info struct with def

[Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

Chris has decided that enough is enough. It's time to fixup dev Vs dev_priv. This is a modest contribution to the crusade. v2: Still use INTEL_INFO(), for the (mythical!) case we want to hardcode the info struct with defines (Chris) Rename the macro argument from 'dev' to 'dev_priv' (Jani)

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

On Mon, Aug 18, 2014 at 11:00:42AM +0100, Damien Lespiau wrote: > Chris has decided that enough is enough. It's time to fixup dev Vs > dev_priv. This is a modest contribution to the crusade. > > v2: Still use INTEL_INFO(), for the (mythical!) case we want to hardcode > the info struct with def

[Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

Chris has decided that enough is enough. It's time to fixup dev Vs dev_priv. This is a modest contribution to the crusade. v2: Still use INTEL_INFO(), for the (mythical!) case we want to hardcode the info struct with defines (Chris) Rename the macro argument from 'dev' to 'dev_priv' (Jani)

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

On Fri, 15 Aug 2014, Damien Lespiau wrote: > Chris has decided that enough is enough. It's time to fixup dev Vs > dev_priv and the, oh so awful, INTEL_INFO(). This is a modest > contribution to the crusade. > -#define for_each_pipe(p) for ((p) = 0; (p) < INTEL_INFO(dev)->num_pipes; > (p)++) > +

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

On Fri, Aug 15, 2014 at 06:34:06PM +0100, Damien Lespiau wrote: > -#define for_each_pipe(p) for ((p) = 0; (p) < INTEL_INFO(dev)->num_pipes; > (p)++) > +#define for_each_pipe(dev, p) for ((p) = 0; (p) < (dev)->info.num_pipes; > (p)++) > #define for_each_sprite(p, s) for ((s) = 0; (s) < > INTEL_I

[Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

Chris has decided that enough is enough. It's time to fixup dev Vs dev_priv and the, oh so awful, INTEL_INFO(). This is a modest contribution to the crusade. Suggested-by: Chris Wilson Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 10 +++--- drivers/gpu/drm/i915/i915_