Re: [Intel-gfx] [PATCH] drm/i915: Wake up all waiters before idling

2017-03-06 Thread Mika Kuoppala
Chris Wilson writes: > When we idle, we wakeup the first waiter (checking to see if it missed > an earlier wakeup) and disarm the breadcrumbs. However, we now assert > that there are no waiter when the interrupt is disabled, triggering an > assert if there were multiple waiters when we idled. > >

Re: [Intel-gfx] [PATCH] drm/i915: Wake up all waiters before idling

2017-03-06 Thread Chris Wilson
On Mon, Mar 06, 2017 at 12:30:17PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > + spin_lock_irq(&b->rb_lock); > > + rbtree_postorder_for_each_entry_safe(wait, n, &b->waiters, node) { > > + RB_CLEAR_NODE(&wait->node); > > + if (wake_up_process(wait->tsk) && wait ==

Re: [Intel-gfx] [PATCH] drm/i915: Wake up all waiters before idling

2017-03-06 Thread Mika Kuoppala
Chris Wilson writes: > When we idle, we wakeup the first waiter (checking to see if it missed > an earlier wakeup) and disarm the breadcrumbs. However, we now assert > that there are no waiter when the interrupt is disabled, triggering an > assert if there were multiple waiters when we idled. > >

[Intel-gfx] [PATCH] drm/i915: Wake up all waiters before idling

2017-03-03 Thread Chris Wilson
When we idle, we wakeup the first waiter (checking to see if it missed an earlier wakeup) and disarm the breadcrumbs. However, we now assert that there are no waiter when the interrupt is disabled, triggering an assert if there were multiple waiters when we idled. [ 420.842275] invalid opcode: 00