Re: [Intel-gfx] [PATCH] drm/i915: Write zero wms if we disable planes for icl+

2022-05-23 Thread Lisovskiy, Stanislav
On Mon, May 23, 2022 at 11:06:05AM +0300, Govindapillai, Vinod wrote: > Hi Stan > > Pls see some comments inline.. > > BR > Vinod > > On Wed, 2022-05-18 at 13:59 +0300, Stanislav Lisovskiy wrote: > > Otherwise we seem to get FIFO underruns. It is being disabled > > anyway, so kind of logical to

Re: [Intel-gfx] [PATCH] drm/i915: Write zero wms if we disable planes for icl+

2022-05-23 Thread Govindapillai, Vinod
Hi Stan Pls see some comments inline.. BR Vinod On Wed, 2022-05-18 at 13:59 +0300, Stanislav Lisovskiy wrote: > Otherwise we seem to get FIFO underruns. It is being disabled > anyway, so kind of logical to write those as zeroes, even if > disabling is temporary. > > Signed-off-by: Stanislav

Re: [Intel-gfx] [PATCH] drm/i915: Write zero wms if we disable planes for icl+

2022-05-18 Thread Ville Syrjälä
On Wed, May 18, 2022 at 03:05:44PM +0300, Lisovskiy, Stanislav wrote: > On Wed, May 18, 2022 at 02:44:30PM +0300, Jani Nikula wrote: > > On Wed, 18 May 2022, Stanislav Lisovskiy > > wrote: > > > Otherwise we seem to get FIFO underruns. It is being disabled > > > anyway, so kind of logical to

Re: [Intel-gfx] [PATCH] drm/i915: Write zero wms if we disable planes for icl+

2022-05-18 Thread Lisovskiy, Stanislav
On Wed, May 18, 2022 at 02:44:30PM +0300, Jani Nikula wrote: > On Wed, 18 May 2022, Stanislav Lisovskiy > wrote: > > Otherwise we seem to get FIFO underruns. It is being disabled > > anyway, so kind of logical to write those as zeroes, even if > > disabling is temporary. > > > > Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915: Write zero wms if we disable planes for icl+

2022-05-18 Thread Jani Nikula
On Wed, 18 May 2022, Stanislav Lisovskiy wrote: > Otherwise we seem to get FIFO underruns. It is being disabled > anyway, so kind of logical to write those as zeroes, even if > disabling is temporary. > > Signed-off-by: Stanislav Lisovskiy > --- > .../drm/i915/display/skl_universal_plane.c|

[Intel-gfx] [PATCH] drm/i915: Write zero wms if we disable planes for icl+

2022-05-18 Thread Stanislav Lisovskiy
Otherwise we seem to get FIFO underruns. It is being disabled anyway, so kind of logical to write those as zeroes, even if disabling is temporary. Signed-off-by: Stanislav Lisovskiy --- .../drm/i915/display/skl_universal_plane.c| 2 +- drivers/gpu/drm/i915/intel_pm.c | 46