Re: [Intel-gfx] [PATCH] drm/i915: add audio_ptr pointer check

2016-03-02 Thread Yang, Libin
Hi Takashi, > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Wednesday, March 02, 2016 4:57 PM > To: Yang, Libin > Cc: libin.y...@linux.intel.com; intel-gfx@lists.freedesktop.org; > conselv...@gmail.com; jani.nik...@linux.intel.com; > ville.syrj...@linux.intel.com;

Re: [Intel-gfx] [PATCH] drm/i915: add audio_ptr pointer check

2016-03-02 Thread Takashi Iwai
On Wed, 02 Mar 2016 08:59:23 +0100, Yang, Libin wrote: > > Hi Takashi, > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Wednesday, March 02, 2016 3:44 PM > > To: libin.y...@linux.intel.com > > Cc: intel-gfx@lists.freedesktop.org; conselv...@gmail.com; > > j

Re: [Intel-gfx] [PATCH] drm/i915: add audio_ptr pointer check

2016-03-02 Thread Yang, Libin
Hi Takashi, > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Wednesday, March 02, 2016 3:44 PM > To: libin.y...@linux.intel.com > Cc: intel-gfx@lists.freedesktop.org; conselv...@gmail.com; > jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com; Vetter, Daniel;

Re: [Intel-gfx] [PATCH] drm/i915: add audio_ptr pointer check

2016-03-02 Thread Jani Nikula
On Wed, 02 Mar 2016, Takashi Iwai wrote: > On Wed, 02 Mar 2016 03:24:31 +0100, > libin.y...@linux.intel.com wrote: >> >> From: Libin Yang >> >> check to make sure audio_ptr is not NULL before >> using it. > > I don't think non-NULL is mandatory. If any invalid access is seen, > it should be fi

Re: [Intel-gfx] [PATCH] drm/i915: add audio_ptr pointer check

2016-03-01 Thread Takashi Iwai
On Wed, 02 Mar 2016 03:24:31 +0100, libin.y...@linux.intel.com wrote: > > From: Libin Yang > > check to make sure audio_ptr is not NULL before > using it. I don't think non-NULL is mandatory. If any invalid access is seen, it should be fixed rather in the audio side. thanks, Takashi > > S

[Intel-gfx] [PATCH] drm/i915: add audio_ptr pointer check

2016-03-01 Thread libin . yang
From: Libin Yang check to make sure audio_ptr is not NULL before using it. Signed-off-by: Libin Yang --- drivers/gpu/drm/i915/intel_audio.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 3