Re: [Intel-gfx] [PATCH] drm/i915: add i915_address_space_fini

2016-11-17 Thread Chris Wilson
On Thu, Nov 17, 2016 at 08:53:15PM +, Matthew Auld wrote: > We already have an i915_address_space_init, so for symmetry we should > also have a _fini, plus we already open code it twice. This then also > fixes a bug where we leak the timeline for the ggtt vm. > > v2: don't forget about the str

[Intel-gfx] [PATCH] drm/i915: add i915_address_space_fini

2016-11-17 Thread Matthew Auld
We already have an i915_address_space_init, so for symmetry we should also have a _fini, plus we already open code it twice. This then also fixes a bug where we leak the timeline for the ggtt vm. v2: don't forget about the struct_mutex for the ggtt path. Fixes: 80b204bce8f2 ("drm/i915: Enable mul

Re: [Intel-gfx] [PATCH] drm/i915: add i915_address_space_fini

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 07:25:17PM +, Matthew Auld wrote: > We already have an i915_address_space_init, so for symmetry we should > also have a _fini, plus we already open code it twice. This then also > fixes a bug where we leak the timeline for the ggtt vm. > > Cc: Chris Wilson > Signed-off

[Intel-gfx] [PATCH] drm/i915: add i915_address_space_fini

2016-11-16 Thread Matthew Auld
We already have an i915_address_space_init, so for symmetry we should also have a _fini, plus we already open code it twice. This then also fixes a bug where we leak the timeline for the ggtt vm. Cc: Chris Wilson Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 17 +