Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-27 Thread Jani Nikula
On Tue, 26 Aug 2014, Daniel Vetter wrote: > On Tue, Aug 26, 2014 at 04:15:53PM +, Scot Doyle wrote: >> On Tue, 26 Aug 2014, Daniel Vetter wrote: >> > On Thu, Aug 21, 2014 at 07:12:59AM +, Scot Doyle wrote: >> >> When we enter intel_modeset_setup_hw_state during resume >> >> - BLC_PWM_CPU_C

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-26 Thread Scot Doyle
On Tue, 26 Aug 2014, Daniel Vetter wrote: > On Tue, Aug 26, 2014 at 07:33:25PM +0200, Daniel Vetter wrote: >> Indeed the bios seems to just but gunk into that register. And if we add >> in all the knobs there's piles of them (you have semi-duplicated backlight >> registers on hsw on the PCH), so I

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 07:33:25PM +0200, Daniel Vetter wrote: > On Tue, Aug 26, 2014 at 04:15:53PM +, Scot Doyle wrote: > > On Tue, 26 Aug 2014, Daniel Vetter wrote: > > > On Thu, Aug 21, 2014 at 07:12:59AM +, Scot Doyle wrote: > > >> When we enter intel_modeset_setup_hw_state during resum

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 04:15:53PM +, Scot Doyle wrote: > On Tue, 26 Aug 2014, Daniel Vetter wrote: > > On Thu, Aug 21, 2014 at 07:12:59AM +, Scot Doyle wrote: > >> When we enter intel_modeset_setup_hw_state during resume > >> - BLC_PWM_CPU_CTL2 == BLM_PWM_ENABLE > >> - the physical backlig

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-26 Thread Scot Doyle
On Tue, 26 Aug 2014, Daniel Vetter wrote: > On Thu, Aug 21, 2014 at 07:12:59AM +, Scot Doyle wrote: >> When we enter intel_modeset_setup_hw_state during resume >> - BLC_PWM_CPU_CTL2 == BLM_PWM_ENABLE >> - the physical backlight is off > > Hm, this is actually interesting - we have some other ev

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-26 Thread Daniel Vetter
On Thu, Aug 21, 2014 at 07:12:59AM +, Scot Doyle wrote: > > On Tue, 19 Aug 2014, Daniel Vetter wrote: > >On Tue, Aug 19, 2014 at 4:07 AM, Scot Doyle wrote: > >>BIOS or firmware can modify hardware state during suspend/resume, > >>for example on the Toshiba CB35 or Lenovo T400, so log a debug

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-21 Thread Scot Doyle
On Tue, 19 Aug 2014, Daniel Vetter wrote: On Tue, Aug 19, 2014 at 4:07 AM, Scot Doyle wrote: BIOS or firmware can modify hardware state during suspend/resume, for example on the Toshiba CB35 or Lenovo T400, so log a debug message instead of a warning if the backlight is unexpectedly enabled.

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-19 Thread Daniel Vetter
On Tue, Aug 19, 2014 at 4:07 AM, Scot Doyle wrote: > BIOS or firmware can modify hardware state during suspend/resume, > for example on the Toshiba CB35 or Lenovo T400, so log a debug message > instead of a warning if the backlight is unexpectedly enabled. > > Bugzilla: https://bugs.freedesktop.or

[Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-18 Thread Scot Doyle
BIOS or firmware can modify hardware state during suspend/resume, for example on the Toshiba CB35 or Lenovo T400, so log a debug message instead of a warning if the backlight is unexpectedly enabled. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80930 Cc: Jani Nikula Signed-off-by: Scot