Re: [Intel-gfx] [PATCH] drm/i915: expose energy counter on SNB and IVB

2012-06-24 Thread Eugeni Dodonov
On 06/24/2012 07:01 AM, Daniel Vetter wrote: > On Fri, Jun 22, 2012 at 07:04:29PM -0700, Ben Widawsky wrote: >> On Wed, 20 Jun 2012 14:48:58 -0700 >> Jesse Barnes wrote: >>> +static struct attribute *gt_attrs[] = { >>> + &dev_attr_gt_energy_uJ.attr, >>> + NULL, >>> +}; >> >> I think convention

Re: [Intel-gfx] [PATCH] drm/i915: expose energy counter on SNB and IVB

2012-06-24 Thread Eugeni Dodonov
On 06/20/2012 06:48 PM, Jesse Barnes wrote: > On SNB and IVB, there's an MSR (also exposed through MCHBAR) we can use > to read out the amount of energy used over time. Expose this in sysfs > to make it easy to do power comparisons with different configurations. > > If the platform supports it, t

Re: [Intel-gfx] [PATCH] drm/i915: expose energy counter on SNB and IVB

2012-06-24 Thread Daniel Vetter
On Fri, Jun 22, 2012 at 07:04:29PM -0700, Ben Widawsky wrote: > On Wed, 20 Jun 2012 14:48:58 -0700 > Jesse Barnes wrote: > > +static struct attribute *gt_attrs[] = { > > + &dev_attr_gt_energy_uJ.attr, > > + NULL, > > +}; > > I think convention dictates it should be all lowercase. And while on

Re: [Intel-gfx] [PATCH] drm/i915: expose energy counter on SNB and IVB

2012-06-22 Thread Ben Widawsky
On Wed, 20 Jun 2012 14:48:58 -0700 Jesse Barnes wrote: > On SNB and IVB, there's an MSR (also exposed through MCHBAR) we can use > to read out the amount of energy used over time. Expose this in sysfs > to make it easy to do power comparisons with different configurations. > > If the platform s

[Intel-gfx] [PATCH] drm/i915: expose energy counter on SNB and IVB

2012-06-20 Thread Jesse Barnes
On SNB and IVB, there's an MSR (also exposed through MCHBAR) we can use to read out the amount of energy used over time. Expose this in sysfs to make it easy to do power comparisons with different configurations. If the platform supports it, the file will show up under the drm/card0/power subdire