Re: [Intel-gfx] [PATCH] drm/i915: fix pm refcounting on fence error in execbuf

2017-02-04 Thread Chris Wilson
On Fri, Feb 03, 2017 at 02:45:29PM -0800, Daniele Ceraolo Spurio wrote: > Fences are creted/checked before the pm ref is taken, so if we jump to > pre_mutex_err we will uncorrectly call intel_runtime_pm_put. > > Fixes: fec0445caa27 (drm/i915: Support explicit fencing for execbuf) > Testcase: igt/g

Re: [Intel-gfx] [PATCH] drm/i915: fix pm refcounting on fence error in execbuf

2017-02-03 Thread Chris Wilson
On Fri, Feb 03, 2017 at 10:55:32PM +, Chris Wilson wrote: > On Fri, Feb 03, 2017 at 02:45:29PM -0800, Daniele Ceraolo Spurio wrote: > > Fences are creted/checked before the pm ref is taken, so if we jump to > > pre_mutex_err we will uncorrectly call intel_runtime_pm_put. > > > > Fixes: fec0445

Re: [Intel-gfx] [PATCH] drm/i915: fix pm refcounting on fence error in execbuf

2017-02-03 Thread Chris Wilson
On Fri, Feb 03, 2017 at 02:45:29PM -0800, Daniele Ceraolo Spurio wrote: > Fences are creted/checked before the pm ref is taken, so if we jump to > pre_mutex_err we will uncorrectly call intel_runtime_pm_put. > > Fixes: fec0445caa27 (drm/i915: Support explicit fencing for execbuf) > Testcase: igt/g

[Intel-gfx] [PATCH] drm/i915: fix pm refcounting on fence error in execbuf

2017-02-03 Thread Daniele Ceraolo Spurio
Fences are creted/checked before the pm ref is taken, so if we jump to pre_mutex_err we will uncorrectly call intel_runtime_pm_put. Fixes: fec0445caa27 (drm/i915: Support explicit fencing for execbuf) Testcase: igt/gem_exec_params Cc: Chris Wilson Signed-off-by: Daniele Ceraolo Spurio --- drive