Re: [Intel-gfx] [PATCH] drm/i915: fix suspend/resume for GENs w/o runtime PM support

2014-08-26 Thread Daniel Vetter
On Mon, Aug 18, 2014 at 01:20:06PM +0300, Imre Deak wrote: Before sharing common parts between the system and runtime s/r handlers we WARNed if the runtime s/r handlers were called on GENs that didn't support RPM. But this WARN is not correct if the same handler is called from the system s/r

Re: [Intel-gfx] [PATCH] drm/i915: fix suspend/resume for GENs w/o runtime PM support

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 09:44:42AM +0200, Daniel Vetter wrote: On Mon, Aug 18, 2014 at 01:20:06PM +0300, Imre Deak wrote: Before sharing common parts between the system and runtime s/r handlers we WARNed if the runtime s/r handlers were called on GENs that didn't support RPM. But this WARN

Re: [Intel-gfx] [PATCH] drm/i915: fix suspend/resume for GENs w/o runtime PM support

2014-08-26 Thread Imre Deak
On Tue, 2014-08-26 at 09:45 +0200, Daniel Vetter wrote: On Tue, Aug 26, 2014 at 09:44:42AM +0200, Daniel Vetter wrote: On Mon, Aug 18, 2014 at 01:20:06PM +0300, Imre Deak wrote: Before sharing common parts between the system and runtime s/r handlers we WARNed if the runtime s/r handlers

[Intel-gfx] [PATCH] drm/i915: fix suspend/resume for GENs w/o runtime PM support

2014-08-18 Thread Imre Deak
Before sharing common parts between the system and runtime s/r handlers we WARNed if the runtime s/r handlers were called on GENs that didn't support RPM. But this WARN is not correct if the same handler is called from the system s/r path, since that can happen on any platform. This also broke

Re: [Intel-gfx] [PATCH] drm/i915: fix suspend/resume for GENs w/o runtime PM support

2014-08-18 Thread Sagar Arun Kamble
Oh. I also missed this side effect of paths converging. Reviewed-by: Sagar Kamble sagar.a.kam...@intel.com On Mon, 2014-08-18 at 13:20 +0300, Imre Deak wrote: Before sharing common parts between the system and runtime s/r handlers we WARNed if the runtime s/r handlers were called on GENs that