Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-17 Thread Imre Deak
On Tue, 2015-11-17 at 22:38 +, Chris Wilson wrote: > On Tue, Nov 17, 2015 at 11:16:09PM +0100, Daniel Vetter wrote: > > On Thu, Nov 5, 2015 at 12:56 PM, Chris Wilson > o.uk> wrote: > > > The tricky part is reviewing the i915_gem_release_mmap() callers > > > to > > > ensure that they have the r

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-17 Thread Chris Wilson
On Tue, Nov 17, 2015 at 11:16:09PM +0100, Daniel Vetter wrote: > On Thu, Nov 5, 2015 at 12:56 PM, Chris Wilson > wrote: > > The tricky part is reviewing the i915_gem_release_mmap() callers to > > ensure that they have the right barrier. If you make > > i915_gem_release_mmap() assert it holds an r

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-17 Thread Daniel Vetter
On Thu, Nov 5, 2015 at 12:56 PM, Chris Wilson wrote: > The tricky part is reviewing the i915_gem_release_mmap() callers to > ensure that they have the right barrier. If you make > i915_gem_release_mmap() assert it holds an rpm ref, and then make the > i915_gem_release_all_mmaps() unlink the node d

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-17 Thread Imre Deak
On ti, 2015-11-17 at 20:00 +0100, Daniel Vetter wrote: > On Wed, Nov 04, 2015 at 05:47:12PM -0200, Paulo Zanoni wrote: > > 2015-11-04 17:25 GMT-02:00 Imre Deak : > > > After Damien's D3 fix I started to get runtime suspend residency > > > for the > > > first time and that revealed a breakage on the

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-17 Thread Daniel Vetter
On Wed, Nov 04, 2015 at 05:47:12PM -0200, Paulo Zanoni wrote: > 2015-11-04 17:25 GMT-02:00 Imre Deak : > > After Damien's D3 fix I started to get runtime suspend residency for the > > first time and that revealed a breakage on the set_caching IOCTL path > > that accesses the HW but doesn't take an

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-16 Thread Jani Nikula
On Wed, 04 Nov 2015, Paulo Zanoni wrote: > 2015-11-04 17:25 GMT-02:00 Imre Deak : >> After Damien's D3 fix I started to get runtime suspend residency for the >> first time and that revealed a breakage on the set_caching IOCTL path >> that accesses the HW but doesn't take an RPM ref. Fix this up. >

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-09 Thread Chris Wilson
On Mon, Nov 09, 2015 at 03:36:10PM +0200, Imre Deak wrote: > On ma, 2015-11-09 at 13:25 +, Chris Wilson wrote: > > On Mon, Nov 09, 2015 at 03:09:18PM +0200, Imre Deak wrote: > > > Looked through it, it seems only i915_gem_set_tiling() could > > > release > > > the PTE's without waking up the ha

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-09 Thread Imre Deak
On ma, 2015-11-09 at 13:25 +, Chris Wilson wrote: > On Mon, Nov 09, 2015 at 03:09:18PM +0200, Imre Deak wrote: > > Looked through it, it seems only i915_gem_set_tiling() could > > release > > the PTE's without waking up the hardware (if no need to unbind the > > object). Otherwise it's true tha

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-09 Thread Chris Wilson
On Mon, Nov 09, 2015 at 03:09:18PM +0200, Imre Deak wrote: > Looked through it, it seems only i915_gem_set_tiling() could release > the PTE's without waking up the hardware (if no need to unbind the > object). Otherwise it's true that all callers hold (or should hold) > already an RPM ref. To fix t

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-09 Thread Imre Deak
On pe, 2015-11-06 at 08:54 +, Chris Wilson wrote: > On Fri, Nov 06, 2015 at 12:57:35AM +0200, Imre Deak wrote: > > On Thu, 2015-11-05 at 11:56 +, Chris Wilson wrote: > > > On Thu, Nov 05, 2015 at 01:28:32PM +0200, Imre Deak wrote: > > > > On ke, 2015-11-04 at 20:57 +, Chris Wilson wrote

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-06 Thread Chris Wilson
On Fri, Nov 06, 2015 at 12:57:35AM +0200, Imre Deak wrote: > On Thu, 2015-11-05 at 11:56 +, Chris Wilson wrote: > > On Thu, Nov 05, 2015 at 01:28:32PM +0200, Imre Deak wrote: > > > On ke, 2015-11-04 at 20:57 +, Chris Wilson wrote: > > > > On Wed, Nov 04, 2015 at 09:25:32PM +0200, Imre Deak

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-05 Thread Imre Deak
On Fri, 2015-11-06 at 00:57 +0200, Imre Deak wrote: > On Thu, 2015-11-05 at 11:56 +, Chris Wilson wrote: > > On Thu, Nov 05, 2015 at 01:28:32PM +0200, Imre Deak wrote: > > > On ke, 2015-11-04 at 20:57 +, Chris Wilson wrote: > > > > On Wed, Nov 04, 2015 at 09:25:32PM +0200, Imre Deak wrote:

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-05 Thread Imre Deak
On Thu, 2015-11-05 at 11:56 +, Chris Wilson wrote: > On Thu, Nov 05, 2015 at 01:28:32PM +0200, Imre Deak wrote: > > On ke, 2015-11-04 at 20:57 +, Chris Wilson wrote: > > > On Wed, Nov 04, 2015 at 09:25:32PM +0200, Imre Deak wrote: > > > > After Damien's D3 fix I started to get runtime suspe

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-05 Thread Chris Wilson
On Thu, Nov 05, 2015 at 01:28:32PM +0200, Imre Deak wrote: > On ke, 2015-11-04 at 20:57 +, Chris Wilson wrote: > > On Wed, Nov 04, 2015 at 09:25:32PM +0200, Imre Deak wrote: > > > After Damien's D3 fix I started to get runtime suspend residency for the > > > first time and that revealed a break

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-05 Thread Imre Deak
On ke, 2015-11-04 at 20:57 +, Chris Wilson wrote: > On Wed, Nov 04, 2015 at 09:25:32PM +0200, Imre Deak wrote: > > After Damien's D3 fix I started to get runtime suspend residency for the > > first time and that revealed a breakage on the set_caching IOCTL path > > that accesses the HW but does

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-04 Thread Chris Wilson
On Wed, Nov 04, 2015 at 09:25:32PM +0200, Imre Deak wrote: > After Damien's D3 fix I started to get runtime suspend residency for the > first time and that revealed a breakage on the set_caching IOCTL path > that accesses the HW but doesn't take an RPM ref. Fix this up. Why here (and in so many ra

Re: [Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-04 Thread Paulo Zanoni
2015-11-04 17:25 GMT-02:00 Imre Deak : > After Damien's D3 fix I started to get runtime suspend residency for the > first time and that revealed a breakage on the set_caching IOCTL path > that accesses the HW but doesn't take an RPM ref. Fix this up. Oh, well, that's the the RPM problem that preve

[Intel-gfx] [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL

2015-11-04 Thread Imre Deak
After Damien's D3 fix I started to get runtime suspend residency for the first time and that revealed a breakage on the set_caching IOCTL path that accesses the HW but doesn't take an RPM ref. Fix this up. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/i915_gem.c | 8 +++- 1 file changed,