Re: [Intel-gfx] [PATCH] drm/i915: make IVB FDI training match spec v3

2013-08-19 Thread Daniel Vetter
On Mon, Aug 19, 2013 at 05:18:47PM -0300, Paulo Zanoni wrote: > 2013/8/19 Jesse Barnes : > > The existing code was trying different vswing and preemphasis settings > > in the wrong place, and wasn't trying them enough. So add a loop to > > walk through them, properly disabling FDI TX and RX in bet

Re: [Intel-gfx] [PATCH] drm/i915: make IVB FDI training match spec v3

2013-08-19 Thread Paulo Zanoni
2013/8/19 Jesse Barnes : > The existing code was trying different vswing and preemphasis settings > in the wrong place, and wasn't trying them enough. So add a loop to > walk through them, properly disabling FDI TX and RX in between if a > failure is detected. > > v2: remove unneeded reg writes, a

[Intel-gfx] [PATCH] drm/i915: make IVB FDI training match spec v3

2013-08-19 Thread Jesse Barnes
The existing code was trying different vswing and preemphasis settings in the wrong place, and wasn't trying them enough. So add a loop to walk through them, properly disabling FDI TX and RX in between if a failure is detected. v2: remove unneeded reg writes, add delays around bit lock checks (Je