[Intel-gfx] [PATCH] drm/i915: properly compute dp dithering for user-created modes

2012-04-10 Thread Daniel Vetter
We've only computed whether we need to fall back to 6bpc due to dp link bandwidth constrains in mode_valid, but not mode_fixup. Under various circumstances X likes to create new modes which then lack proper 6bpc flags (if required), resulting in mode_fixup failures and ultimately black screens. Th

[Intel-gfx] [PATCH] drm/i915: properly compute dp dithering for user-created modes

2012-04-10 Thread Daniel Vetter
We've only computed whether we need to fall back to 6bpc due to dp link bandwidth constrains in mode_valid, but not mode_fixup. Under various circumstances X likes to create new modes which then lack proper 6bpc flags (if required), resulting in mode_fixup failures and ultimately black screens. Ch

[Intel-gfx] [PATCH] drm/i915: properly compute dp dithering for user-created modes

2012-04-10 Thread Daniel Vetter
We've only computed whether we need to fall back to 6bpc due to dp link bandwidth constrains in mode_valid, but not mode_fixup. Under various circumstances X likes to create new modes which then lack proper 6bpc flags (if required), resulting in mode_fixup failures and ultimately black screens. Ch

Re: [Intel-gfx] [PATCH] drm/i915: properly compute dp dithering for user-created modes

2012-04-10 Thread Chris Wilson
On Tue, 10 Apr 2012 09:33:19 +0200, Daniel Vetter wrote: > We've only computed whether we need to fall back to 6bpc due to dp > link bandwidth constrains in mode_valid, but not mode_fixup. Under > various circumstances X likes to create new modes which then lack > proper 6bpc flags (if required),

Re: [Intel-gfx] [PATCH] drm/i915: properly compute dp dithering for user-created modes

2012-04-10 Thread Adam Jackson
On 4/10/12 4:42 AM, Daniel Vetter wrote: We've only computed whether we need to fall back to 6bpc due to dp link bandwidth constrains in mode_valid, but not mode_fixup. Under various circumstances X likes to create new modes which then lack proper 6bpc flags (if required), resulting in mode_fixup

Re: [Intel-gfx] [PATCH] drm/i915: properly compute dp dithering for user-created modes

2012-04-10 Thread Daniel Vetter
On Tue, Apr 10, 2012 at 09:46:53AM -0400, Adam Jackson wrote: > On 4/10/12 4:42 AM, Daniel Vetter wrote: > >We've only computed whether we need to fall back to 6bpc due to dp > >link bandwidth constrains in mode_valid, but not mode_fixup. Under > >various circumstances X likes to create new modes w

Re: [Intel-gfx] [PATCH] drm/i915: properly compute dp dithering for user-created modes

2012-04-10 Thread Keith Packard
<#part sign=pgpmime> On Tue, 10 Apr 2012 09:46:53 -0400, Adam Jackson wrote: > Certainly an improvement. > > Reviewed-by: Adam Jackson I'd like to know if this actually helps someone before I stick it in drm-intel-fixes... -- keith.pack...@intel.com __