Re: [Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-03-11 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 01:36:00PM +, Damien Lespiau wrote: > On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote: > > Spell all the PCI IDs out to be able to quickly grep for the IDs. No > > functional changes. > > > > Signed-off-by: Jani Nikula > > > > --- > > > > I tested this by

Re: [Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5706 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -5 283/283

Re: [Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 01:36:00PM +, Damien Lespiau wrote: > On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote: > > Spell all the PCI IDs out to be able to quickly grep for the IDs. No > > functional changes. > > > > Signed-off-by: Jani Nikula > > > > --- > > > > I tested this by

Re: [Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread Damien Lespiau
On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote: > Spell all the PCI IDs out to be able to quickly grep for the IDs. No > functional changes. > > Signed-off-by: Jani Nikula > > --- > > I tested this by comparing the results of > > $ make drivers/gpu/drm/i915/i915_drv.s > $ make arc

Re: [Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 03:05:05PM +0200, Jani Nikula wrote: > On Tue, 03 Feb 2015, Chris Wilson wrote: > > On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote: > >> Spell all the PCI IDs out to be able to quickly grep for the IDs. No > >> functional changes. > > > > On the other hand this

Re: [Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread Jani Nikula
On Tue, 03 Feb 2015, Chris Wilson wrote: > On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote: >> Spell all the PCI IDs out to be able to quickly grep for the IDs. No >> functional changes. > > On the other hand this is a loss of contextual information in the header > file. I assume the

Re: [Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote: > Spell all the PCI IDs out to be able to quickly grep for the IDs. No > functional changes. On the other hand this is a loss of contextual information in the header file. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___

[Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread Jani Nikula
Spell all the PCI IDs out to be able to quickly grep for the IDs. No functional changes. Signed-off-by: Jani Nikula --- I tested this by comparing the results of $ make drivers/gpu/drm/i915/i915_drv.s $ make arch/x86/kernel/early-quirks.s before and after the patch. No change. --- include/dr