Re: [Intel-gfx] [PATCH] drm/i915: replace snb_update_wm with haswell_update_wm on HSW

2013-05-25 Thread Daniel Vetter
On Fri, May 24, 2013 at 6:20 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Fri, May 24, 2013 at 06:13:15PM +0200, Daniel Vetter wrote: On Fri, May 24, 2013 at 6:07 PM, Daniel Vetter dan...@ffwll.ch wrote: pfit_size stores the request mode, which matches crtc-config.requested

Re: [Intel-gfx] [PATCH] drm/i915: replace snb_update_wm with haswell_update_wm on HSW

2013-05-24 Thread Paulo Zanoni
2013/5/22 Ville Syrjälä ville.syrj...@linux.intel.com: On Tue, May 21, 2013 at 06:24:38PM -0300, Paulo Zanoni wrote: Hi 2013/5/20 Ville Syrjälä ville.syrj...@linux.intel.com: On Thu, May 09, 2013 at 05:13:41PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com We

Re: [Intel-gfx] [PATCH] drm/i915: replace snb_update_wm with haswell_update_wm on HSW

2013-05-24 Thread Daniel Vetter
On Fri, May 24, 2013 at 12:05:15PM -0300, Paulo Zanoni wrote: 2013/5/22 Ville Syrjälä ville.syrj...@linux.intel.com: On Tue, May 21, 2013 at 06:24:38PM -0300, Paulo Zanoni wrote: Hi 2013/5/20 Ville Syrjälä ville.syrj...@linux.intel.com: On Thu, May 09, 2013 at 05:13:41PM -0300, Paulo

Re: [Intel-gfx] [PATCH] drm/i915: replace snb_update_wm with haswell_update_wm on HSW

2013-05-24 Thread Daniel Vetter
On Fri, May 24, 2013 at 6:07 PM, Daniel Vetter dan...@ffwll.ch wrote: pfit_size stores the request mode, which matches crtc-config.requested mode. Instead of jumping through hoops I think I'd be better to directly use those values ... Scrap that, I can't read code ;-) -Daniel -- Daniel Vetter

Re: [Intel-gfx] [PATCH] drm/i915: replace snb_update_wm with haswell_update_wm on HSW

2013-05-24 Thread Ville Syrjälä
On Fri, May 24, 2013 at 06:13:15PM +0200, Daniel Vetter wrote: On Fri, May 24, 2013 at 6:07 PM, Daniel Vetter dan...@ffwll.ch wrote: pfit_size stores the request mode, which matches crtc-config.requested mode. Instead of jumping through hoops I think I'd be better to directly use those

Re: [Intel-gfx] [PATCH] drm/i915: replace snb_update_wm with haswell_update_wm on HSW

2013-05-22 Thread Ville Syrjälä
On Tue, May 21, 2013 at 06:24:38PM -0300, Paulo Zanoni wrote: Hi 2013/5/20 Ville Syrjälä ville.syrj...@linux.intel.com: On Thu, May 09, 2013 at 05:13:41PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com We were previously calling sandybridge_update_wm on HSW, but

Re: [Intel-gfx] [PATCH] drm/i915: replace snb_update_wm with haswell_update_wm on HSW

2013-05-21 Thread Ville Syrjälä
On Thu, May 09, 2013 at 05:13:41PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com We were previously calling sandybridge_update_wm on HSW, but the SNB function didn't really match the HSW specification, so we were just writing the wrong values. For example, I was not

[Intel-gfx] [PATCH] drm/i915: replace snb_update_wm with haswell_update_wm on HSW

2013-05-09 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com We were previously calling sandybridge_update_wm on HSW, but the SNB function didn't really match the HSW specification, so we were just writing the wrong values. For example, I was not seeing any LP watermark ever enabled. This patch implements the

[Intel-gfx] [PATCH] drm/i915: replace snb_update_wm with haswell_update_wm on HSW

2013-05-06 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com We were previously calling sandybridge_update_wm on HSW, but the SNB function didn't really match the HSW specification, so we were just writing the wrong values. For example, I was not seeing any LP watermark ever enabled. So this patch implements the