Re: [Intel-gfx] [PATCH] drm/i915: tidy up gen8_init_scratch

2016-04-27 Thread Joonas Lahtinen
On ke, 2016-04-27 at 15:30 +0300, Mika Kuoppala wrote: > Matthew Auld writes: > > > > > [ text/plain ] > > Prefer a goto teardown path to do all the required cleanup. > > > > v2: > > (Joonas Lahtinen) > >   - remove NULL assignments > >   - rename goto labels > > > > Cc: Mika Kuoppala > > Cc:

Re: [Intel-gfx] [PATCH] drm/i915: tidy up gen8_init_scratch

2016-04-27 Thread Mika Kuoppala
Matthew Auld writes: > [ text/plain ] > Prefer a goto teardown path to do all the required cleanup. > > v2: > (Joonas Lahtinen) > - remove NULL assignments > - rename goto labels > > Cc: Mika Kuoppala > Cc: Dave Gordon > Cc: Joonas Lahtinen > Signed-off-by: Matthew Auld Reviewed-by: Mika

[Intel-gfx] [PATCH] drm/i915: tidy up gen8_init_scratch

2016-04-27 Thread Matthew Auld
Prefer a goto teardown path to do all the required cleanup. v2: (Joonas Lahtinen) - remove NULL assignments - rename goto labels Cc: Mika Kuoppala Cc: Dave Gordon Cc: Joonas Lahtinen Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 25 - 1 fil

Re: [Intel-gfx] [PATCH] drm/i915: tidy up gen8_init_scratch

2016-04-27 Thread Mika Kuoppala
Dave Gordon writes: > [ text/plain ] > On 26/04/16 10:27, Matthew Auld wrote: >> Use goto teardown path and also ensure we reset any struct members which >> would otherwise contain an error encoded pointer, and could be mistaken >> for a valid address. >> >> Cc: Joonas Lahtinen >> Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915: tidy up gen8_init_scratch

2016-04-27 Thread Dave Gordon
On 26/04/16 10:27, Matthew Auld wrote: Use goto teardown path and also ensure we reset any struct members which would otherwise contain an error encoded pointer, and could be mistaken for a valid address. Cc: Joonas Lahtinen Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c

Re: [Intel-gfx] [PATCH] drm/i915: tidy up gen8_init_scratch

2016-04-27 Thread Joonas Lahtinen
On ti, 2016-04-26 at 10:27 +0100, Matthew Auld wrote: > Use goto teardown path and also ensure we reset any struct members which > would otherwise contain an error encoded pointer, and could be mistaken > for a valid address. > > Cc: Joonas Lahtinen > Signed-off-by: Matthew Auld As this goes th

[Intel-gfx] [PATCH] drm/i915: tidy up gen8_init_scratch

2016-04-26 Thread Matthew Auld
Use goto teardown path and also ensure we reset any struct members which would otherwise contain an error encoded pointer, and could be mistaken for a valid address. Cc: Joonas Lahtinen Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 36 +---