Re: [Intel-gfx] [PATCH] drm: Check if primary mst is null

Thanks for noticing this one! With the changes that Ville mentioned in their response: Reviewed-by: Lyude Paul If you need me to push this for you; poke me here or on IRC On Wed, 2018-11-07 at 18:11 +0200, Stanislav Lisovskiy wrote: > Unfortunately drm_dp_get_mst_branch_device which is called

Re: [Intel-gfx] [PATCH] drm: Check if primary mst is null

On Wed, Nov 07, 2018 at 06:11:30PM +0200, Stanislav Lisovskiy wrote: > Unfortunately drm_dp_get_mst_branch_device which is called from both > drm_dp_mst_handle_down_rep and drm_dp_mst_handle_up_rep seem to rely > on that mgr->mst_primary is not NULL, which seem to be wrong as it can be > cleared

[Intel-gfx] [PATCH] drm: Check if primary mst is null

Unfortunately drm_dp_get_mst_branch_device which is called from both drm_dp_mst_handle_down_rep and drm_dp_mst_handle_up_rep seem to rely on that mgr->mst_primary is not NULL, which seem to be wrong as it can be cleared with simultaneous mode set, if probing fails or in other case. mgr->lock mutex