Re: [Intel-gfx] [PATCH] drm: Reject unknown legacy bpp and dpeth for drm_mode_addfb ioctl

2018-09-05 Thread Chris Wilson
Quoting Daniel Vetter (2018-09-04 22:46:33) > On Tue, Sep 04, 2018 at 09:53:19PM +0100, Chris Wilson wrote: > > Since this is handling user provided bpp and depth, we need to sanity > > check and propagate the EINVAL back rather than assume what the insane > > client intended and fill the logs with

Re: [Intel-gfx] [PATCH] drm: Reject unknown legacy bpp and dpeth for drm_mode_addfb ioctl

2018-09-04 Thread Daniel Vetter
On Tue, Sep 04, 2018 at 09:53:19PM +0100, Chris Wilson wrote: > Since this is handling user provided bpp and depth, we need to sanity > check and propagate the EINVAL back rather than assume what the insane > client intended and fill the logs with DRM_ERROR. > > Signed-off-by: Chris Wilson > Cc:

[Intel-gfx] [PATCH] drm: Reject unknown legacy bpp and dpeth for drm_mode_addfb ioctl

2018-09-04 Thread Chris Wilson
Since this is handling user provided bpp and depth, we need to sanity check and propagate the EINVAL back rather than assume what the insane client intended and fill the logs with DRM_ERROR. Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: Ville Syrjälä --- So I am presuming that r.pixel_forma