Re: [Intel-gfx] [PATCH] drm: drm_connector->s/connector_id/index/ for consistency

2016-07-20 Thread Chris Wilson
On Tue, Jul 19, 2016 at 06:25:01PM +0200, Daniel Vetter wrote: > connector_id in the uapi actually means drm_connector->base.id, which > is something entirely different. And ->index is also consistent with > plane/encoder/CRTCS and the various drm_*_index() functions. > > While at it also improve/

[Intel-gfx] [PATCH] drm: drm_connector->s/connector_id/index/ for consistency

2016-07-19 Thread Daniel Vetter
connector_id in the uapi actually means drm_connector->base.id, which is something entirely different. And ->index is also consistent with plane/encoder/CRTCS and the various drm_*_index() functions. While at it also improve/align the kerneldoc comment. v2: Mention where those ids are from ... v

[Intel-gfx] [PATCH] drm: drm_connector->s/connector_id/index/ for consistency

2016-07-19 Thread Daniel Vetter
connector_id in the uapi actually means drm_connector->base.id, which is something entirely different. And ->index is also consistent with plane/encoder/CRTCS and the various drm_*_index() functions. While at it also improve/align the kerneldoc comment. v2: Mention where those ids are from ... v

Re: [Intel-gfx] [PATCH] drm: drm_connector->s/connector_id/index/ for consistency

2016-07-19 Thread Daniel Vetter
On Tue, Jul 19, 2016 at 12:57:52PM +0200, Daniel Vetter wrote: > connector_id in the uapi actually means drm_connector->base.id, which > is something entirely different. And ->index is also consistent with > plane/encoder/CRTCS and the various drm_*_index() functions. > > While at it also improve/

Re: [Intel-gfx] [PATCH] drm: drm_connector->s/connector_id/index/ for consistency

2016-07-19 Thread Chris Wilson
On Tue, Jul 19, 2016 at 12:57:52PM +0200, Daniel Vetter wrote: > connector_id in the uapi actually means drm_connector->base.id, which > is something entirely different. And ->index is also consistent with > plane/encoder/CRTCS and the various drm_*_index() functions. > > While at it also improve/

[Intel-gfx] [PATCH] drm: drm_connector->s/connector_id/index/ for consistency

2016-07-19 Thread Daniel Vetter
connector_id in the uapi actually means drm_connector->base.id, which is something entirely different. And ->index is also consistent with plane/encoder/CRTCS and the various drm_*_index() functions. While at it also improve/align the kerneldoc comment. v2: Mention where those ids are from ... C