Re: [Intel-gfx] [PATCH] drmtest: don't discard return value in do_ioctl()

2016-05-05 Thread Robert Bragg
On Thu, May 5, 2016 at 4:59 PM, Chris Wilson wrote: > On Thu, May 05, 2016 at 04:06:02PM +0100, Robert Bragg wrote: > > Fixed a rebase mistake where I dropped the use of the igt_ioctl wrapper > in > > do_ioctl(). > > > > I'm not entirely sure a.t.m whether the assertion

Re: [Intel-gfx] [PATCH] drmtest: don't discard return value in do_ioctl()

2016-05-05 Thread Chris Wilson
On Thu, May 05, 2016 at 04:06:02PM +0100, Robert Bragg wrote: > Fixed a rebase mistake where I dropped the use of the igt_ioctl wrapper in > do_ioctl(). > > I'm not entirely sure a.t.m whether the assertion change from ret == 0 to > ret >= 0 will break anything, though comparing run-tests.sh -s

[Intel-gfx] [PATCH] drmtest: don't discard return value in do_ioctl()

2016-05-05 Thread Robert Bragg
Fixed a rebase mistake where I dropped the use of the igt_ioctl wrapper in do_ioctl(). I'm not entirely sure a.t.m whether the assertion change from ret == 0 to ret >= 0 will break anything, though comparing run-tests.sh -s -t basic before/after didn't seem to highlight a problem for me. --- >8