Re: [Intel-gfx] [PATCH] i915/guc: Run busyness worker only if gt is awake

2023-09-14 Thread Daniele Ceraolo Spurio
On 9/11/2023 5:52 PM, Umesh Nerlige Ramappa wrote: The worker is canceled in the __gt_park path, but we still see it running sometimes during suspend. Only update stats if gt is awake. If not, intel_guc_busyness_park would have already updated the stats. Note that we do not requeue the worker

[Intel-gfx] [PATCH] i915/guc: Run busyness worker only if gt is awake

2023-09-11 Thread Umesh Nerlige Ramappa
The worker is canceled in the __gt_park path, but we still see it running sometimes during suspend. Only update stats if gt is awake. If not, intel_guc_busyness_park would have already updated the stats. Note that we do not requeue the worker if gt is not awake since intel_guc_busyness_unpark

Re: [Intel-gfx] [PATCH] i915/guc: Run busyness worker only if gt is awake

2023-09-11 Thread Umesh Nerlige Ramappa
On Mon, Sep 11, 2023 at 08:44:39AM -0700, Daniele Ceraolo Spurio wrote: On 9/8/2023 10:16 PM, Umesh Nerlige Ramappa wrote: The worker is canceled in the __gt_park path, but we still see it running sometimes during suspend. This is likely because some code is getting a gt wakeref in the

Re: [Intel-gfx] [PATCH] i915/guc: Run busyness worker only if gt is awake

2023-09-11 Thread Daniele Ceraolo Spurio
On 9/8/2023 10:16 PM, Umesh Nerlige Ramappa wrote: The worker is canceled in the __gt_park path, but we still see it running sometimes during suspend. This is likely because some code is getting a gt wakeref in the __gt_park path. This possible root-cause doesn't seem plausible to me, because

[Intel-gfx] [PATCH] i915/guc: Run busyness worker only if gt is awake

2023-09-08 Thread Umesh Nerlige Ramappa
The worker is canceled in the __gt_park path, but we still see it running sometimes during suspend. This is likely because some code is getting a gt wakeref in the __gt_park path. Only update stats if gt is awake. If not, intel_guc_busyness_park would have already updated the stats. Note that we