Re: [Intel-gfx] [PATCH] i915: remove pm_qos request on error

2014-01-25 Thread Daniel Vetter
On Sat, Jan 25, 2014 at 10:13:37AM +0100, Stanislaw Gruszka wrote: > Not removing pm qos request and free memory for it can cause crash, > when some other driver use pm qos. For example, this oops: > > BUG: unable to handle kernel paging request at fff8 > IP: [] plist_add+0x5b/0xd0 > C

[Intel-gfx] [PATCH] i915: remove pm_qos request on error

2014-01-25 Thread Stanislaw Gruszka
Not removing pm qos request and free memory for it can cause crash, when some other driver use pm qos. For example, this oops: BUG: unable to handle kernel paging request at fff8 IP: [] plist_add+0x5b/0xd0 Call Trace: [] pm_qos_update_target+0x125/0x1e0 [] pm_qos_add_request+0x91/0x1