Re: [Intel-gfx] [PATCH] rendercopy/gen8: Remove a hole in struct gen8_blend_state

2014-03-26 Thread Damien Lespiau
On Wed, Mar 26, 2014 at 06:45:11PM +, Barbalho, Rafael wrote: > > -Original Message- > > From: Lespiau, Damien > > Sent: Monday, March 24, 2014 11:54 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Widawsky, Benjamin; Barbalho, Rafael > > Subject: [PATCH] rendercopy/gen8: Remove a ho

Re: [Intel-gfx] [PATCH] rendercopy/gen8: Remove a hole in struct gen8_blend_state

2014-03-26 Thread Barbalho, Rafael
> -Original Message- > From: Lespiau, Damien > Sent: Monday, March 24, 2014 11:54 AM > To: intel-gfx@lists.freedesktop.org > Cc: Widawsky, Benjamin; Barbalho, Rafael > Subject: [PATCH] rendercopy/gen8: Remove a hole in struct > gen8_blend_state > > Using uint64_t in that second member make

Re: [Intel-gfx] [PATCH] rendercopy/gen8: Remove a hole in struct gen8_blend_state

2014-03-24 Thread Ben Widawsky
On Mon, Mar 24, 2014 at 06:53:47PM +, Damien Lespiau wrote: > Using uint64_t in that second member makes it aligned to 64bits, while > the first member is only 32bits. We then had a 32bits hole in there! > > Found-by: Chris Wilson > Cc: Ben Widawsky > Cc: Rafael Barbalho > Signed-off-by: Da

[Intel-gfx] [PATCH] rendercopy/gen8: Remove a hole in struct gen8_blend_state

2014-03-24 Thread Damien Lespiau
Using uint64_t in that second member makes it aligned to 64bits, while the first member is only 32bits. We then had a 32bits hole in there! Found-by: Chris Wilson Cc: Ben Widawsky Cc: Rafael Barbalho Signed-off-by: Damien Lespiau --- lib/gen8_render.h | 38 +++-