Re: [Intel-gfx] [PATCH] sna/uxa: Fix colormap handling at screen depth 30.

2018-03-16 Thread Ville Syrjälä
On Fri, Mar 16, 2018 at 12:19:22AM +0100, Mario Kleiner wrote: > I made a proof of concept patchset against i915-kms to use the 1024 > slot, 10 bit wide hw lut's starting with Ironlake, and to upsample > from the legacy 256 slots to those 1024 slot luts. Also some hacks to > enable dithering from

Re: [Intel-gfx] [PATCH] sna/uxa: Fix colormap handling at screen depth 30.

2018-03-15 Thread Mario Kleiner
Oops, didn't reply yet, sorry! On Thu, Mar 15, 2018 at 5:14 PM, Chris Wilson wrote: > Quoting Ville Syrjälä (2018-03-15 16:02:42) >> On Thu, Mar 15, 2018 at 03:28:18PM +, Chris Wilson wrote: >> > Quoting Ville Syrjälä (2018-03-01 11:12:53) >> > > On Thu, Mar 01,

Re: [Intel-gfx] [PATCH] sna/uxa: Fix colormap handling at screen depth 30.

2018-03-15 Thread Chris Wilson
Quoting Ville Syrjälä (2018-03-15 16:02:42) > On Thu, Mar 15, 2018 at 03:28:18PM +, Chris Wilson wrote: > > Quoting Ville Syrjälä (2018-03-01 11:12:53) > > > On Thu, Mar 01, 2018 at 02:20:48AM +0100, Mario Kleiner wrote: > > > > The various clut handling functions like a setup > > > >

Re: [Intel-gfx] [PATCH] sna/uxa: Fix colormap handling at screen depth 30.

2018-03-15 Thread Ville Syrjälä
On Thu, Mar 15, 2018 at 03:28:18PM +, Chris Wilson wrote: > Quoting Ville Syrjälä (2018-03-01 11:12:53) > > On Thu, Mar 01, 2018 at 02:20:48AM +0100, Mario Kleiner wrote: > > > The various clut handling functions like a setup > > > consistent with the x-screen color depth. Otherwise > > > we

Re: [Intel-gfx] [PATCH] sna/uxa: Fix colormap handling at screen depth 30.

2018-03-15 Thread Chris Wilson
Quoting Ville Syrjälä (2018-03-01 11:12:53) > On Thu, Mar 01, 2018 at 02:20:48AM +0100, Mario Kleiner wrote: > > The various clut handling functions like a setup > > consistent with the x-screen color depth. Otherwise > > we observe improper sampling in the gamma tables > > at depth 30. > > > >

Re: [Intel-gfx] [PATCH] sna/uxa: Fix colormap handling at screen depth 30.

2018-03-01 Thread Ville Syrjälä
On Thu, Mar 01, 2018 at 02:20:48AM +0100, Mario Kleiner wrote: > The various clut handling functions like a setup > consistent with the x-screen color depth. Otherwise > we observe improper sampling in the gamma tables > at depth 30. > > Therefore replace hard-coded bitsPerRGB = 8 by actual >

[Intel-gfx] [PATCH] sna/uxa: Fix colormap handling at screen depth 30.

2018-02-28 Thread Mario Kleiner
The various clut handling functions like a setup consistent with the x-screen color depth. Otherwise we observe improper sampling in the gamma tables at depth 30. Therefore replace hard-coded bitsPerRGB = 8 by actual bits per channel scrn->rgbBits. Also use this for call to xf86HandleColormaps().