Re: [Intel-gfx] [PATCH] sna: move up the assert check before DBG print message

2016-03-01 Thread Lim, Siew Hoon
> On Tue, Mar 01, 2016 at 10:33:12AM +, Lim, Siew Hoon wrote: > > > > > > On Tue, Mar 01, 2016 at 09:49:21AM +0800, Lim Siew Hoon wrote: > > > > The assert check for c->bo should be done before DBG, else it will > > > > hit memory access violation when c->bo is null. > > > > > > > > Signed-off-

Re: [Intel-gfx] [PATCH] sna: move up the assert check before DBG print message

2016-03-01 Thread Chris Wilson
On Tue, Mar 01, 2016 at 10:33:12AM +, Lim, Siew Hoon wrote: > > > > On Tue, Mar 01, 2016 at 09:49:21AM +0800, Lim Siew Hoon wrote: > > > The assert check for c->bo should be done before DBG, else it will hit > > > memory access violation when c->bo is null. > > > > > > Signed-off-by: Lim Siew

Re: [Intel-gfx] [PATCH] sna: move up the assert check before DBG print message

2016-03-01 Thread Lim, Siew Hoon
> > On Tue, Mar 01, 2016 at 09:49:21AM +0800, Lim Siew Hoon wrote: > > The assert check for c->bo should be done before DBG, else it will hit > > memory access violation when c->bo is null. > > > > Signed-off-by: Lim Siew Hoon > > Reviewed-by: Matt Roper > > Pardon? With a r-b? What is a r-b?

Re: [Intel-gfx] [PATCH] sna: move up the assert check before DBG print message

2016-03-01 Thread Chris Wilson
On Tue, Mar 01, 2016 at 09:49:21AM +0800, Lim Siew Hoon wrote: > The assert check for c->bo should be done before DBG, > else it will hit memory access violation when c->bo > is null. > > Signed-off-by: Lim Siew Hoon > Reviewed-by: Matt Roper Pardon? With a r-b? -Chris -- Chris Wilson, Intel

[Intel-gfx] [PATCH] sna: move up the assert check before DBG print message

2016-02-29 Thread Lim Siew Hoon
The assert check for c->bo should be done before DBG, else it will hit memory access violation when c->bo is null. Signed-off-by: Lim Siew Hoon Reviewed-by: Matt Roper Signed-off-by: Matt Roper --- src/sna/sna_dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sna/s