Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-23 Thread Daniel Vetter
...@gmail.com] *Sent:* 2015年4月22日 10:30 *To:* weiyj...@163.com; Daniel Vetter; Jani Nikula; David Airlie; Yongjun Wei (RD-CN); intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; open list *Subject:* Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from

Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-23 Thread John Hunter
@lists.freedesktop.org; dri-de...@lists.freedesktop.org; open list *Subject:* Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c Hi, I think maybe we should remove both of the two lines: #include intel_drv.h #include i915_drv.h

Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-22 Thread John Hunter
Hi, I think maybe we should remove both of the two lines: #include intel_drv.h #include i915_drv.h Because we have* two* intel_drv.h and *one* i915_drv.h, and i915_drv.h has already been included in the intel_drv.h. I not sure whether i am right. If you need me to do the patch, let me know. On

Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-22 Thread yongjun_...@trendmicro.com.cn
Subject: Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c Hi, I think maybe we should remove both of the two lines: #include intel_drv.h #include i915_drv.h Because we have two intel_drv.h and one i915_drv.h, and i915_drv.h has already been included

Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-22 Thread John Hunter
Nikula; David Airlie; Yongjun Wei (RD-CN); intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; open list *Subject:* Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c Hi, I think maybe we should remove both of the two lines: #include