On Tue, Mar 25, 2014 at 12:46:37PM -0700, Volkin, Bradley D wrote:
> On Tue, Mar 25, 2014 at 06:15:36AM -0700, Daniel Vetter wrote:
> > - Secure batch dispatch is still fubar.
>
> I'm not sure that this will still impact us once we implement the batch copy
> step. I was only using the secure dispa
On Tue, Mar 25, 2014 at 06:15:36AM -0700, Daniel Vetter wrote:
> On Thu, Mar 20, 2014 at 04:43:05PM +0200, Jani Nikula wrote:
> >
> > Hi Bradley -
> >
> > Apologies for my procrastination with the review; I don't easily recall
> > as tedious a review as the command and register tables. And I sure
On Tue, 25 Mar 2014, Daniel Vetter wrote:
> On Thu, Mar 20, 2014 at 04:43:05PM +0200, Jani Nikula wrote:
>>
>> Hi Bradley -
>>
>> Apologies for my procrastination with the review; I don't easily recall
>> as tedious a review as the command and register tables. And I sure have
>> reviewed a lot o
On Thu, Mar 20, 2014 at 04:43:05PM +0200, Jani Nikula wrote:
>
> Hi Bradley -
>
> Apologies for my procrastination with the review; I don't easily recall
> as tedious a review as the command and register tables. And I sure have
> reviewed a lot of miserable stuff in the past.
>
> Most infuriatin
Hi Bradley -
Apologies for my procrastination with the review; I don't easily recall
as tedious a review as the command and register tables. And I sure have
reviewed a lot of miserable stuff in the past.
Most infuriatingly, I did not find a single real bug in the code!
I think we'll need to aut
On Tue, Mar 11, 2014 at 05:41:06AM -0700, Jani Nikula wrote:
>
> Hi Bradley -
>
> I've now rather meticulously reviewed what *is* in the command and
> register tables, and didn't spot any obvious errors.
Thanks Jani! I know it's a huge pain, so I appreciate you taking the
time for it.
>
> Ther
Hi Bradley -
I've now rather meticulously reviewed what *is* in the command and
register tables, and didn't spot any obvious errors.
There is still the review of what is *not* in the command and register
tables, but perhaps should be. This is important for two reasons:
1) Any command that shoul
On Wed, Mar 05, 2014 at 09:14:38AM -0800, Daniel Vetter wrote:
> On Wed, Mar 05, 2014 at 08:59:56AM -0800, Volkin, Bradley D wrote:
> > On Wed, Mar 05, 2014 at 02:46:35AM -0800, Daniel Vetter wrote:
> > > On Tue, Feb 18, 2014 at 10:15:44AM -0800, bradley.d.vol...@intel.com
> > > wrote:
> > > > Fro
On Wed, Mar 05, 2014 at 08:59:56AM -0800, Volkin, Bradley D wrote:
> On Wed, Mar 05, 2014 at 02:46:35AM -0800, Daniel Vetter wrote:
> > On Tue, Feb 18, 2014 at 10:15:44AM -0800, bradley.d.vol...@intel.com wrote:
> > > From: Brad Volkin
> > > 3) Coherency. I've previously found a coherency issue on
On Wed, Mar 05, 2014 at 02:46:35AM -0800, Daniel Vetter wrote:
> On Tue, Feb 18, 2014 at 10:15:44AM -0800, bradley.d.vol...@intel.com wrote:
> > From: Brad Volkin
> > 3) Coherency. I've previously found a coherency issue on VLV when reading
> > the
> >batch buffer from the CPU during execbuff
On Tue, Feb 18, 2014 at 10:15:44AM -0800, bradley.d.vol...@intel.com wrote:
> From: Brad Volkin
>
> Certain OpenGL features (e.g. transform feedback, performance monitoring)
> require userspace code to submit batches containing commands such as
> MI_LOAD_REGISTER_IMM to access various registers.
Daniel, Jani,
I think I managed to send this while you were both out and I'm sure it got
buried. Can you take a look? I think this rev addresses all of the current
comments.
Thanks,
Brad
On Tue, Feb 18, 2014 at 10:15:44AM -0800, Volkin, Bradley D wrote:
> From: Brad Volkin
>
> Certain OpenGL f
From: Brad Volkin
Certain OpenGL features (e.g. transform feedback, performance monitoring)
require userspace code to submit batches containing commands such as
MI_LOAD_REGISTER_IMM to access various registers. Unfortunately, some
generations of the hardware will noop these commands in "unsecure"
FYI, I did an initial review "sweep" of this. Will focus more on the
logic and registers etc. next.
BR,
Jani.
On Wed, 29 Jan 2014, bradley.d.vol...@intel.com wrote:
> From: Brad Volkin
>
> Certain OpenGL features (e.g. transform feedback, performance monitoring)
> require userspace code to sub
On Wed, Jan 29, 2014 at 02:22:49PM -0800, Volkin, Bradley D wrote:
> On Wed, Jan 29, 2014 at 02:11:17PM -0800, Daniel Vetter wrote:
> > On Wed, Jan 29, 2014 at 01:55:01PM -0800, bradley.d.vol...@intel.com wrote:
> > > From: Brad Volkin
> > > 3) Coherency. I've found a coherency issue on VLV when r
On Wed, Jan 29, 2014 at 02:11:17PM -0800, Daniel Vetter wrote:
> On Wed, Jan 29, 2014 at 01:55:01PM -0800, bradley.d.vol...@intel.com wrote:
> > From: Brad Volkin
> > 3) Coherency. I've found a coherency issue on VLV when reading the batch
> > buffer
> >from the CPU during execbuffer2. Usersp
On Wed, Jan 29, 2014 at 01:55:01PM -0800, bradley.d.vol...@intel.com wrote:
> From: Brad Volkin
> 3) Coherency. I've found a coherency issue on VLV when reading the batch
> buffer
>from the CPU during execbuffer2. Userspace writes the batch via pwrite fast
>path before calling execbuffer2
From: Brad Volkin
Certain OpenGL features (e.g. transform feedback, performance monitoring)
require userspace code to submit batches containing commands such as
MI_LOAD_REGISTER_IMM to access various registers. Unfortunately, some
generations of the hardware will noop these commands in "unsecure"
18 matches
Mail list logo
