Re: [Intel-gfx] [PATCH 01/13] drm/i915: Flush the context object from the CPU caches upon creation

2012-07-14 Thread Daniel Vetter
On Sat, Jul 14, 2012 at 2:48 PM, Chris Wilson wrote: > On Sat, 14 Jul 2012 13:58:58 +0200, Daniel Vetter wrote: >> So afact this first patch here seems to add another instance of the very >> bug this patch series tries squash ... Additionally I'm still hunting for >> that other failure case, whic

Re: [Intel-gfx] [PATCH 01/13] drm/i915: Flush the context object from the CPU caches upon creation

2012-07-14 Thread Chris Wilson
On Sat, 14 Jul 2012 13:58:58 +0200, Daniel Vetter wrote: > So afact this first patch here seems to add another instance of the very > bug this patch series tries squash ... Additionally I'm still hunting for > that other failure case, which can't be fixed by adding the flush in > execbuffer if rin

Re: [Intel-gfx] [PATCH 01/13] drm/i915: Flush the context object from the CPU caches upon creation

2012-07-14 Thread Daniel Vetter
On Fri, Jul 13, 2012 at 02:14:04PM +0100, Chris Wilson wrote: > Signed-off-by: Chris Wilson > Cc: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_gem_context.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_context.c > b/dr

Re: [Intel-gfx] [PATCH 01/13] drm/i915: Flush the context object from the CPU caches upon creation

2012-07-14 Thread Chris Wilson
On Fri, 13 Jul 2012 17:54:54 +0200, Daniel Vetter wrote: > I think only the first hunk should be part of this patch - the later two > hunks make more sense squashed together with the last patch. At least that > would avoid me going a bit wtf here and then again on the last patch where > the from_o

Re: [Intel-gfx] [PATCH 01/13] drm/i915: Flush the context object from the CPU caches upon creation

2012-07-13 Thread Daniel Vetter
On Fri, Jul 13, 2012 at 02:14:04PM +0100, Chris Wilson wrote: > Signed-off-by: Chris Wilson > Cc: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_gem_context.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_context.c > b/dr

Re: [Intel-gfx] [PATCH 01/13] drm/i915: Flush the context object from the CPU caches upon creation

2012-07-13 Thread Ben Widawsky
On Fri, 13 Jul 2012 14:14:04 +0100 Chris Wilson wrote: > Signed-off-by: Chris Wilson > Cc: Ben Widawsky I guess setting the read_domains is now superfluous. Reviewed-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_gem_context.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 d

[Intel-gfx] [PATCH 01/13] drm/i915: Flush the context object from the CPU caches upon creation

2012-07-13 Thread Chris Wilson
Signed-off-by: Chris Wilson Cc: Ben Widawsky --- drivers/gpu/drm/i915/i915_gem_context.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c index 9ae3f2c..90857f8 100644 --- a/driv