Re: [Intel-gfx] [PATCH 01/18] drm/i915/guc: Use a local cancel_port_requests

2019-08-19 Thread Janusz Krzysztofik
On Monday, August 12, 2019 10:23:29 PM CEST Daniele Ceraolo Spurio wrote: > > On 8/12/19 6:38 AM, Chris Wilson wrote: > > Since execlista and the guc have diverged in their port tracking, we > > cannot simply reuse the execlists cancellation code as it leads to > > unbalanced reference counting.

Re: [Intel-gfx] [PATCH 01/18] drm/i915/guc: Use a local cancel_port_requests

2019-08-12 Thread Daniele Ceraolo Spurio
On 8/12/19 6:38 AM, Chris Wilson wrote: Since execlista and the guc have diverged in their port tracking, we cannot simply reuse the execlists cancellation code as it leads to unbalanced reference counting. Use a local simpler routine for the guc. LGTM, just wondering if we should put a

[Intel-gfx] [PATCH 01/18] drm/i915/guc: Use a local cancel_port_requests

2019-08-12 Thread Chris Wilson
Since execlista and the guc have diverged in their port tracking, we cannot simply reuse the execlists cancellation code as it leads to unbalanced reference counting. Use a local simpler routine for the guc. Signed-off-by: Chris Wilson Cc: Daniele Ceraolo Spurio ---