Re: [Intel-gfx] [PATCH 01/18] drm/i915: Unify intel_logical_ring_emit and intel_ring_emit

2016-07-21 Thread Chris Wilson
On Thu, Jul 21, 2016 at 02:26:19PM +0300, Joonas Lahtinen wrote: > On ke, 2016-07-20 at 14:11 +0100, Chris Wilson wrote: > > Both perform the same actions with more or less indirection, so just > > unify the code. > > > > Don't really like removing the engine = req->engine aliases, but seems >

Re: [Intel-gfx] [PATCH 01/18] drm/i915: Unify intel_logical_ring_emit and intel_ring_emit

2016-07-21 Thread Joonas Lahtinen
On ke, 2016-07-20 at 14:11 +0100, Chris Wilson wrote: > Both perform the same actions with more or less indirection, so just > unify the code. > Don't really like removing the engine = req->engine aliases, but seems like req->engine is used plenty already. And assuming this was a mechanical

[Intel-gfx] [PATCH 01/18] drm/i915: Unify intel_logical_ring_emit and intel_ring_emit

2016-07-20 Thread Chris Wilson
Both perform the same actions with more or less indirection, so just unify the code. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_context.c| 54 ++-- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 53 ++-- drivers/gpu/drm/i915/i915_gem_gtt.c