Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-13 Thread Vlastimil Babka
On 07/12/2018 08:45 AM, Joe Perches wrote: > On Wed, 2018-07-11 at 20:50 +0200, Daniel Vetter wrote: >> On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: >>> On 7/11/18 10:45 AM, Tejun Heo wrote: On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: > On Mon, Jul 09, 2018 at 10:36:4

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-12 Thread Joe Perches
On Thu, 2018-07-12 at 07:54 -0600, Jens Axboe wrote: > > Thanks for your invaluable and useful feedback, sharing your vast > experience in patchsets with dependencies. I've probably more experience sending patchsets with dependencies across subsystems than anyone. There is no single style that w

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-12 Thread Jens Axboe
On 7/12/18 12:45 AM, Joe Perches wrote: > On Wed, 2018-07-11 at 20:50 +0200, Daniel Vetter wrote: >> On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: >>> On 7/11/18 10:45 AM, Tejun Heo wrote: On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: > On Mon, Jul 09, 2018 at 10:36:40AM

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Joe Perches
On Wed, 2018-07-11 at 20:50 +0200, Daniel Vetter wrote: > On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: > > On 7/11/18 10:45 AM, Tejun Heo wrote: > > > On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: > > > > On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: > > > > > M

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 03:13:00PM -0600, Jens Axboe wrote: > On 7/11/18 3:08 PM, Daniel Vetter wrote: > > On Wed, Jul 11, 2018 at 10:06 PM, Tejun Heo wrote: > >> On Wed, Jul 11, 2018 at 01:31:51PM -0600, Jens Axboe wrote: > >>> I don't think there's a git easy way of sending it out outside of > >

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Jens Axboe
On 7/11/18 3:08 PM, Daniel Vetter wrote: > On Wed, Jul 11, 2018 at 10:06 PM, Tejun Heo wrote: >> On Wed, Jul 11, 2018 at 01:31:51PM -0600, Jens Axboe wrote: >>> I don't think there's a git easy way of sending it out outside of >>> just ensuring that everybody is CC'ed on everything. I don't mind >

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 10:06 PM, Tejun Heo wrote: > On Wed, Jul 11, 2018 at 01:31:51PM -0600, Jens Axboe wrote: >> I don't think there's a git easy way of sending it out outside of >> just ensuring that everybody is CC'ed on everything. I don't mind >> that at all. I don't subscribe to lkml, and

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Tejun Heo
On Wed, Jul 11, 2018 at 01:31:51PM -0600, Jens Axboe wrote: > I don't think there's a git easy way of sending it out outside of > just ensuring that everybody is CC'ed on everything. I don't mind > that at all. I don't subscribe to lkml, and the patches weren't > sent to linux-block. Hence all I se

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Jens Axboe
On 7/11/18 12:50 PM, Daniel Vetter wrote: > On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: >> On 7/11/18 10:45 AM, Tejun Heo wrote: >>> On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: > Makes the macros resilien

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: > On 7/11/18 10:45 AM, Tejun Heo wrote: >> On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: >>> On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: Makes the macros resilient against if {} else {} blocks right afterw

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Jens Axboe
On 7/11/18 10:45 AM, Tejun Heo wrote: > On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: >> On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: >>> Makes the macros resilient against if {} else {} blocks right >>> afterwards. >>> >>> Signed-off-by: Daniel Vetter >>> Cc: Tejun

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Tejun Heo
On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: > On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: > > Makes the macros resilient against if {} else {} blocks right > > afterwards. > > > > Signed-off-by: Daniel Vetter > > Cc: Tejun Heo > > Cc: Jens Axboe > > Cc: Shaohua

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Tejun Heo
On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: > Makes the macros resilient against if {} else {} blocks right > afterwards. > > Signed-off-by: Daniel Vetter > Cc: Tejun Heo > Cc: Jens Axboe > Cc: Shaohua Li > Cc: Kate Stewart > Cc: Greg Kroah-Hartman > Cc: Joseph Qi > Cc: D

[Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-09 Thread Daniel Vetter
Makes the macros resilient against if {} else {} blocks right afterwards. Signed-off-by: Daniel Vetter Cc: Tejun Heo Cc: Jens Axboe Cc: Shaohua Li Cc: Kate Stewart Cc: Greg Kroah-Hartman Cc: Joseph Qi Cc: Daniel Vetter Cc: Arnd Bergmann --- include/linux/blk-cgroup.h | 4 ++-- 1 file cha