Re: [Intel-gfx] [PATCH 02/46] drm/i915: Revoke mmaps and prevent access to fence registers across reset

2019-02-26 Thread Chris Wilson
Quoting Rodrigo Vivi (2019-02-26 19:53:47) > On Wed, Feb 06, 2019 at 01:03:12PM +, Chris Wilson wrote: > > Previously, we were able to rely on the recursive properties of > > struct_mutex to allow us to serialise revoking mmaps and reacquiring the > > FENCE registers with them being clobbered o

Re: [Intel-gfx] [PATCH 02/46] drm/i915: Revoke mmaps and prevent access to fence registers across reset

2019-02-26 Thread Rodrigo Vivi
On Wed, Feb 06, 2019 at 01:03:12PM +, Chris Wilson wrote: > Previously, we were able to rely on the recursive properties of > struct_mutex to allow us to serialise revoking mmaps and reacquiring the > FENCE registers with them being clobbered over a global device reset. > I then proceeded to th

Re: [Intel-gfx] [PATCH 02/46] drm/i915: Revoke mmaps and prevent access to fence registers across reset

2019-02-06 Thread Chris Wilson
Quoting Chris Wilson (2019-02-06 16:08:23) > Quoting Mika Kuoppala (2019-02-06 15:56:28) > > Chris Wilson writes: > > > @@ -5358,6 +5326,8 @@ void i915_gem_cleanup_early(struct drm_i915_private > > > *dev_priv) > > > GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); > > > WARN_ON(dev

Re: [Intel-gfx] [PATCH 02/46] drm/i915: Revoke mmaps and prevent access to fence registers across reset

2019-02-06 Thread Chris Wilson
Quoting Mika Kuoppala (2019-02-06 15:56:28) > Chris Wilson writes: > > @@ -5358,6 +5326,8 @@ void i915_gem_cleanup_early(struct drm_i915_private > > *dev_priv) > > GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count)); > > WARN_ON(dev_priv->mm.object_count); > > > > synchronize_rcu and s

Re: [Intel-gfx] [PATCH 02/46] drm/i915: Revoke mmaps and prevent access to fence registers across reset

2019-02-06 Thread Mika Kuoppala
Chris Wilson writes: > Previously, we were able to rely on the recursive properties of > struct_mutex to allow us to serialise revoking mmaps and reacquiring the > FENCE registers with them being clobbered over a global device reset. > I then proceeded to throw out the baby with the bath water in

[Intel-gfx] [PATCH 02/46] drm/i915: Revoke mmaps and prevent access to fence registers across reset

2019-02-06 Thread Chris Wilson
Previously, we were able to rely on the recursive properties of struct_mutex to allow us to serialise revoking mmaps and reacquiring the FENCE registers with them being clobbered over a global device reset. I then proceeded to throw out the baby with the bath water in order to pursue a struct_mutex