Re: [Intel-gfx] [PATCH 03/12] drm/i915: make PDE|PTE platform specific

2013-05-08 Thread Daniel Vetter
On Wed, May 8, 2013 at 6:49 PM, Ben Widawsky wrote: >> I've written this code, so I know what the magic 512 is all about. But >> since Jesse is already confused about them I don't like removing the >> #define that much. Heck, we even tend to use PAGE_SIZE instead of 4096. >> >> What about a GEN6_

Re: [Intel-gfx] [PATCH 03/12] drm/i915: make PDE|PTE platform specific

2013-05-08 Thread Ben Widawsky
On Mon, May 06, 2013 at 11:47:42AM +0200, Daniel Vetter wrote: > On Thu, May 02, 2013 at 02:26:17PM -0700, Jesse Barnes wrote: > > On Tue, 23 Apr 2013 23:15:31 -0700 > > Ben Widawsky wrote: > > > > > Accomplish this be removing the PDE count define which is (and has > > > always been) part of the

Re: [Intel-gfx] [PATCH 03/12] drm/i915: make PDE|PTE platform specific

2013-05-06 Thread Daniel Vetter
On Thu, May 02, 2013 at 02:26:17PM -0700, Jesse Barnes wrote: > On Tue, 23 Apr 2013 23:15:31 -0700 > Ben Widawsky wrote: > > > Accomplish this be removing the PDE count define which is (and has > > always been) part of the PPGTT structure anyway. With the addition of > > the gen specific init fun

Re: [Intel-gfx] [PATCH 03/12] drm/i915: make PDE|PTE platform specific

2013-05-02 Thread Jesse Barnes
On Thu, 2 May 2013 15:49:17 -0700 Ben Widawsky wrote: > On Thu, May 02, 2013 at 02:26:17PM -0700, Jesse Barnes wrote: > > On Tue, 23 Apr 2013 23:15:31 -0700 > > Ben Widawsky wrote: > > > > > Accomplish this be removing the PDE count define which is (and has > > > always been) part of the PPGTT

Re: [Intel-gfx] [PATCH 03/12] drm/i915: make PDE|PTE platform specific

2013-05-02 Thread Ben Widawsky
On Thu, May 02, 2013 at 02:26:17PM -0700, Jesse Barnes wrote: > On Tue, 23 Apr 2013 23:15:31 -0700 > Ben Widawsky wrote: > > > Accomplish this be removing the PDE count define which is (and has > > always been) part of the PPGTT structure anyway. With the addition of > > the gen specific init fun

Re: [Intel-gfx] [PATCH 03/12] drm/i915: make PDE|PTE platform specific

2013-05-02 Thread Jesse Barnes
On Tue, 23 Apr 2013 23:15:31 -0700 Ben Widawsky wrote: > Accomplish this be removing the PDE count define which is (and has > always been) part of the PPGTT structure anyway. With the addition of > the gen specific init function, we can nicely tuck away the magic number > in there. > > In this v

[Intel-gfx] [PATCH 03/12] drm/i915: make PDE|PTE platform specific

2013-04-23 Thread Ben Widawsky
Accomplish this be removing the PDE count define which is (and has always been) part of the PPGTT structure anyway. With the addition of the gen specific init function, we can nicely tuck away the magic number in there. In this vain, make the PTE define less of a magic number. The remaining code